3 ms·
+1 to the other comments about having linting and CI to reduce the nitpicks and basic verification in PRs. One technique I've used and liked is to have the PR
by aaronharnly 11y ago
+1 to the other comments about having linting and CI to reduce the nitpicks and basic verification in PRs.
One technique I've used and liked is to have the PR author create a calendar invite for the review, usually with enough lead time to be reasonable, eg the following afternoon. This isn't an old-fashioned "everyone get in a conference room" code review -- you still it do it individually at your machine -- but it allocates the time.
The author puts one or two people that they would like to review as required, and the rest of the team as optional. That helps the reviewers carve out time to get it done, encourages people to RSVP as either reviewing or not, and makes for a well-understood deadline when to get your comments in by if you want to have any influence on the PR.
It's not a perfect system, but might be worth giving a try if you are having problems getting prompt sign-up for reviews.
- takno 11y agoMy experience is more as a roadblock than as somebody getting code live (although I have been held up by my own cursed rules a couple of times). I'd have to say that I really appreciate the calendar approach - it gives me a time slot to think about the code, and more importantly it forces me to stop prevaricating and make a decision so that I'm no longer blocking others