4 ms·
It's also the case that you lose the code review if you force push to a PR's branch after adding in a typo fix and squashing locally, right? That's a pretty go
by Tyr42 11y ago
It's also the case that you lose the code review if you force push to a PR's branch after adding in a typo fix and squashing locally, right?
That's a pretty good reason not to squash till the review is done.
- JoshTriplett 11y ago> It's also the case that you lose the code review if you force push to a PR's branch after adding in a typo fix and squashing locally, right? Not as far as I can tell; I've force-pushed pull request branches many times, and the code reviews seem to stick around. (Perhaps they wouldn't if the code changed more drastically, like files disappearing; I haven't tried that.)