3 ms·

So thats two pretty major bugs in iOS9.3 (the failing upgrade process for older hardware is the other big issue - and Apple are getting lots of support calls ab

by kenshi 11y ago

So thats two pretty major bugs in iOS9.3 (the failing upgrade process for older hardware is the other big issue - and Apple are getting lots of support calls about it). I really have to wonder what has happened to Apple's Quality Control. More money, more bugs?

chris_wot 11y ago
Check out this patch: https://bugs.webkit.org/attachment.cgi?id=268394&action=diff https://bugs.webkit.org/attachment.cgi?id=268394&action=diff [iOS] Revert overflow:hidden on the body affecting viewport scale (r186786) https://bugs.webkit.org/show_bug.cgi?id=152803 https://bugs.webkit.org/show_bug.cgi?id=152803 Reviewed by NOBODY (OOPS!). Bug was reported on 6th January, broke thousands of websites, was patched shortly thereafter - and deployed 3 months later. Three months to fix a major regression snafu. Apple Safari support sucks.
- darinf 11y ago
  This is just reverting a change that was found to be bad. Returning to a known good state makes sense.
  - chris_wot 11y ago
    Not sure I understand your point. That bad state got into the 9.2 release, was reverted and three months later got into 9.3. In the meantime thousands of sites break, and the Apple support forums are bursting at the seams with people asking about this issue. It's hardly "just reverting a change that was found to be bad". The impact was huge!
- progers7 11y ago
  This was reviewed properly, you just have to click the actual commit: http://trac.webkit.org/changeset/194667 http://trac.webkit.org/changeset/194667 "Reviewed by Tim Horton." The response time here might not be great, but the patch author and reviewer are both experts in this area. I wouldn't consider this patch evidence of declining software quality--it's just a simple bug.
  - chris_wot 11y ago
    You seem a bit confused. I'm not saying the revert of the patch wasn't reviewed. I'm saying the commit that caused the issue wasn't reviewed. Hope this helps.
    - progers7 11y ago
      This is the commit that caused the bug: http://trac.webkit.org/changeset/186786 http://trac.webkit.org/changeset/186786 Notice the review line
      - chris_wot 11y ago
        Damn, you're right and I've made myself look foolish. I apologise for my tone and reaction.

by kenshi 11y ago

chris_wot 11y ago

Check out this patch: https://bugs.webkit.org/attachment.cgi?id=268394&action=diff https://bugs.webkit.org/attachment.cgi?id=268394&action=diff [iOS] Revert overflow:hidden on the body affecting viewport scale (r186786) https://bugs.webkit.org/show_bug.cgi?id=152803 https://bugs.webkit.org/show_bug.cgi?id=152803 Reviewed by NOBODY (OOPS!). Bug was reported on 6th January, broke thousands of websites, was patched shortly thereafter - and deployed 3 months later. Three months to fix a major regression snafu. Apple Safari support sucks.

darinf 11y ago
This is just reverting a change that was found to be bad. Returning to a known good state makes sense.
- chris_wot 11y ago
  Not sure I understand your point. That bad state got into the 9.2 release, was reverted and three months later got into 9.3. In the meantime thousands of sites break, and the Apple support forums are bursting at the seams with people asking about this issue. It's hardly "just reverting a change that was found to be bad". The impact was huge!
progers7 11y ago
This was reviewed properly, you just have to click the actual commit: http://trac.webkit.org/changeset/194667 http://trac.webkit.org/changeset/194667 "Reviewed by Tim Horton." The response time here might not be great, but the patch author and reviewer are both experts in this area. I wouldn't consider this patch evidence of declining software quality--it's just a simple bug.
- chris_wot 11y ago
  You seem a bit confused. I'm not saying the revert of the patch wasn't reviewed. I'm saying the commit that caused the issue wasn't reviewed. Hope this helps.
  - progers7 11y ago
    This is the commit that caused the bug: http://trac.webkit.org/changeset/186786 http://trac.webkit.org/changeset/186786 Notice the review line
    - chris_wot 11y ago
      Damn, you're right and I've made myself look foolish. I apologise for my tone and reaction.