4 ms·

The things I miss the most using Gitlab vs github are the instantaneous merges and the syntax highlighting within diffs when reviewing a MR. I'm on an old-ish

• sytse 11y ago
  We have syntax highlighting within diffs since 8.4 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2109 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2109 so please consider upgrading. I don't understand what you mean with instantaneous merges, did merges seem faster in the past? We do have a feature that allows you to merge when the build is successful, saving many people lot of time http://doc.gitlab.com/ce/workflow/merge_when_build_succeeds.html http://doc.gitlab.com/ce/workflow/merge_when_build_succeeds....
  • dpritchett 11y ago
    We're on 8.1 I think. We are running a largeish C# project with largeish diffs; when I click "merge" the app spins for a good few seconds or more before completing the merge. Don't think I've ever seen that sort of delay on github. I wonder if you could pre-merge in a separate system branch then do some git magic to rearrange them once the user actually clicks merge?
    • sytse 11y ago
      Pre-merging when you look at the merge request is an interesting idea. Technically that will work but it will add complexity and use more resources. Feel free to make a feature request for it. At this point I think there is lower hanging fruit we can pick to improve performance.
      • dpritchett 11y ago
        I wouldn't prioritize it if I were you either ;)
        • sytse 11y ago
          Thanks for understanding :)