4 ms·
This is a great step in the right direction. I use GitHub for code review every day, and it has historically been very poorly designed for thorough reviews. The
by danpalmer 11y ago
This is a great step in the right direction. I use GitHub for code review every day, and it has historically been very poorly designed for thorough reviews. These changes look great, I just hope that we get some sort of checking-off of review points, and accept/reject functionality.
- avolcano 11y agoI wonder if there's a set of API hooks they could expose to allow third party applications to handle more advanced code review techniques? I would totally understand GitHub not wanting to implement a full Phabricator/Gerrit review feature set, but maybe they could make it easier to integrate other services for it.
- moby 11y agoThat's a great thought. For my own edification, which third party apps come to mind? At present, the "official" collaboration tools in the GitHub integrations directory are here: https://github.com/integrations/feature/collaborate https://github.com/integrations/feature/collaborate
- ed_blackburn 11y agoI agree. I think there's a whole ecosystem there.
- cmsj 11y agoI don't understand it :) GitHub has become the de-facto place to host open source projects. Improving the tooling around code merging, seems like a no-brainer, and a huge potential win for the projects using it, especially the larger ones.
- erichurkman 11y agoI'd love a UI way to enable `?w=1` whitespace mode, especially for html/json/yaml files. I have a feeling a lot of reviewers don't know about it and spend an inordinate amount of time squinting to see what changes when it was a whitespace-only change.
- nathankleyn 11y agoSome similar option for enabling patience diffing as well would be amazing. Those two options in combination would certainly make a not insignificant amount of PRs much more readable.
- wclax04 11y agoI REALLY wish I could exclude certain file types from the view.
- tyingq 11y agoThis! ?w=1 has existed for years, with no UI way to access it. Compare two views of the same commit (found this by searching for any commit on github with the word "indent" in it) https://github.com/douglascrockford/JSON-js/commit/1e3869cb398ddf58d3d52efd735067093dc5bf3e https://github.com/douglascrockford/JSON-js/commit/1e3869cb3... (133 additions and 127 deletions) https://github.com/douglascrockford/JSON-js/commit/1e3869cb398ddf58d3d52efd735067093dc5bf3e?w=1 https://github.com/douglascrockford/JSON-js/commit/1e3869cb3... (30 additions and 24 deletions)
- xPaw 11y agoI have a userscript that does just that, however it needs to be updated to account for these new review tools. https://gist.github.com/xPaw/de6ee132a2e267ef6960 https://gist.github.com/xPaw/de6ee132a2e267ef6960
- mwarkentin 11y agoOn top of that.. when you're in `?w=1` view you can't leave line-by-line comments. :facepalm:
- alxndr 11y agoI created a reminder for myself so that every six months I write an email to GitHub asking for someone to create a user option for this whitespace setting.
- faitswulff 11y agoIt's interesting that you mention checking off of review points. I had begun to do that in an informal fashion by updating my pull request with notes in the form of a checklist: - [x] Refactor _ - [ ] Rename variable x - [ ] ... Now that you mention it, it would be very nice to have something like Google Docs's ability to mark comments as resolved.
- deleted 11y ago[deleted]
- danpalmer 11y agoUnfortunately that doesn't work for us for 2 reasons - 1. There's a data loss bug when multiple people edit the PR descriptions. I've had that as an open issue with GitHub for ~6 months, my team experiences it several times a week. 2. We use the checkboxes to assign and track reviewers, and since there's only one count of checkboxes, it would mess with our "2 of 5 complete" kind of metric for reviews. I'd like first-class support for the concept of people reviewing and accepting (or rejecting) so that it's taken out of the PR description.
- marcinkuzminski 11y agoThis is exactly how voting, and reviewers concept works in RhodeCode. You have accept/reject/under review states for each reviewer, and you have to make full voting in order to merge a PR.
- nightpool 11y agoQuestion: why do you use checklists to assign reviewers, when github has that functionality built in?
- jbrooksuk 11y agoBecause GitHub only allows you to assign to one person per issue.
- 11y ago