3 ms·
Nice idea, nice design, horrible code behind it. Just a look at rtu.js made me cry. Never mix logic and presentation. Especially in such security-crucial proje
by plugnburn 11y ago
Nice idea, nice design, horrible code behind it.
Just a look at rtu.js made me cry. Never mix logic and presentation. Especially in such security-crucial projects.
I don't know what is the server side written in but it seems horrible too: I managed to upload the same file twice and returned a link in the same directory but with different names (boomer.mid and boomer(1).mid). So it's possible to flood all the server space with the same file unlimited amount of time. This is definitely a security issue. Also, a name mustn't change over time: my (or anyone else's) next boomer.mid upload mustn't become boomer(2).mid.
I haven't tried it yet but I hope server-side filetype validation is also present? Otherwise the server is going to have big troubles over time...