4 ms·

Been using gitlab for a while and its mostly good. The only thing that is letting it down for us is the code review tools which are not as good as some of the o

by jab213 11y ago

Been using gitlab for a while and its mostly good. The only thing that is letting it down for us is the code review tools which are not as good as some of the other dedicated tools on the market. The big gripes are: * the ability to assign a review to multiple users * set a number of reviewers * Multiline comments * review publishing * Review versions Not really noticed any problems with speed but its good to see that they are working on it anyway :)

sytse 11y ago
Thanks for your feedback. Have you seen the merge request approvers feature in GitLab EE/.com https://about.gitlab.com/2015/06/16/feature-highlight-approve-merge-request/ https://about.gitlab.com/2015/06/16/feature-highlight-approv... ? I would love to see multiline comments too! See https://gitlab.com/gitlab-org/gitlab-ce/issues/4143 https://gitlab.com/gitlab-org/gitlab-ce/issues/4143 Review publishing, do you mean https://gitlab.com/gitlab-org/gitlab-ce/issues/3364 https://gitlab.com/gitlab-org/gitlab-ce/issues/3364 ? Review version, what do you mean with this?
- jab214 11y ago
  "Thanks for your feedback. Have you seen the merge request approvers feature in GitLab EE/.com https://about.gitlab.com/2015/06/16/feature-highlight-approv.. https://about.gitlab.com/2015/06/16/feature-highlight-approv.... ?" Yes saw that. Currently evaluating various git servers as its something we use a lot. But would really want to assign the review to particular (or a group of) people i.e. the more experienced people in a team. "I would love to see multiline comments too! See https://gitlab.com/gitlab-org/gitlab-ce/issues/4143" https://gitlab.com/gitlab-org/gitlab-ce/issues/4143" Cool. Didn't see that - will add my vote if I can. "Review publishing, do you mean https://gitlab.com/gitlab-org/gitlab-ce/issues/3364 https://gitlab.com/gitlab-org/gitlab-ce/issues/3364 ?" Basically yes. "Review version, what do you mean with this?" Thinking about it not sure that this is really necessary in the git world. Back in svn days seeing the diffs versioned was handy but with merge request you can see the commit history so its not necessary.
  - sytse 11y ago
    Thanks! "But would really want to assign the review to particular (or a group of) people i.e. the more experienced people in a team." => doesn't https://about.gitlab.com/2015/06/16/feature-highlight-approve-merge-request/ https://about.gitlab.com/2015/06/16/feature-highlight-approv... allow that? We seem to be in sync on all other feature requests.

by jab213 11y ago

sytse 11y ago

Thanks for your feedback. Have you seen the merge request approvers feature in GitLab EE/.com https://about.gitlab.com/2015/06/16/feature-highlight-approve-merge-request/ https://about.gitlab.com/2015/06/16/feature-highlight-approv... ? I would love to see multiline comments too! See https://gitlab.com/gitlab-org/gitlab-ce/issues/4143 https://gitlab.com/gitlab-org/gitlab-ce/issues/4143 Review publishing, do you mean https://gitlab.com/gitlab-org/gitlab-ce/issues/3364 https://gitlab.com/gitlab-org/gitlab-ce/issues/3364 ? Review version, what do you mean with this?

jab214 11y ago
"Thanks for your feedback. Have you seen the merge request approvers feature in GitLab EE/.com https://about.gitlab.com/2015/06/16/feature-highlight-approv.. https://about.gitlab.com/2015/06/16/feature-highlight-approv.... ?" Yes saw that. Currently evaluating various git servers as its something we use a lot. But would really want to assign the review to particular (or a group of) people i.e. the more experienced people in a team. "I would love to see multiline comments too! See https://gitlab.com/gitlab-org/gitlab-ce/issues/4143" https://gitlab.com/gitlab-org/gitlab-ce/issues/4143" Cool. Didn't see that - will add my vote if I can. "Review publishing, do you mean https://gitlab.com/gitlab-org/gitlab-ce/issues/3364 https://gitlab.com/gitlab-org/gitlab-ce/issues/3364 ?" Basically yes. "Review version, what do you mean with this?" Thinking about it not sure that this is really necessary in the git world. Back in svn days seeing the diffs versioned was handy but with merge request you can see the commit history so its not necessary.
- sytse 11y ago
  Thanks! "But would really want to assign the review to particular (or a group of) people i.e. the more experienced people in a team." => doesn't https://about.gitlab.com/2015/06/16/feature-highlight-approve-merge-request/ https://about.gitlab.com/2015/06/16/feature-highlight-approv... allow that? We seem to be in sync on all other feature requests.