5 ms·
How does allowing `:`, `\n`, and a bunch of other characters that might be problematic in a Unix or Windows shell fix anything? What if every time someone deman
by nanis 11y ago
How does allowing `:`, `\n`, and a bunch of other characters that might be problematic in a Unix or Windows shell fix anything? What if every time someone demanded "change these seven characters," project maintainers complied?
Without a test, without a clear problem spec, without an explanation of why those specific seven characters are the fix.
What would happen then?
- deckar01 11y agoThey opened a new pull request and merged it. https://github.com/remy/nodemon/pull/789 https://github.com/remy/nodemon/pull/789 A few bad habits I noticed: - Adding a "chore" commit to an unrelated pull request. (like an earmarked bill) - Modifying the source with no explaination in a commit that should only add tests. (and didn't add a test for that change)
- citrusx 11y agoFWIW (non-technical readers)... The issue, I think, is that the \w escape sequence doesn't include characters that are outside what Unicode considered "word characters" at the time it was originally implemented. So, non-western characters that are higher up in number don't get picked up by \w. The strategy here was to change the regex to mean, "accept any character that isn't something that's illegal for a file name".