3 ms·

Feel free to open an issue both for the http clone without .git, it seems interesting but I'm not sure how complicated it is. Not sure about the git:// read on

by sytse 11y ago

Feel free to open an issue both for the http clone without .git, it seems interesting but I'm not sure how complicated it is. Not sure about the git:// read only url, I don't oversee the consequences.

mintplant 11y ago
git has a default user agent that looks like git/2.0.0, so you could detect that and redirect. I believe this is how GitHub makes this work.
jacobvosmaer 11y ago
The git:// protocol requires its own daemon (which is bundled with Git) running on port 9418 https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols#The-Git-Protocol https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protoco... . The standard Git daemon is unsuitable for GitLab I think because of the way it manages access control. https://git-scm.com/book/en/v2/Git-on-the-Server-Git-Daemon https://git-scm.com/book/en/v2/Git-on-the-Server-Git-Daemon For this to work in GitLab we would need to find or write an alternative implementation of the protocol. Sounds like a lot of work to me when we already have decent HTTP clone access.
- jacobvosmaer 11y ago
  Hmm I was wrong, the current version of the built-in Git daemon has an --access-hook option so no problem there. https://github.com/git/git/blob/56f37fda511e1615dc6df86c68f3b841711a7828/daemon.c#L291 https://github.com/git/git/blob/56f37fda511e1615dc6df86c68f3... The question is then: how badly do people want this and how many admins out there are willing to poke an extra hole in their firewall just for this protocol.
  - jacobvosmaer 11y ago
    https://gitlab.com/gitlab-org/gitlab-ce/issues/13838 https://gitlab.com/gitlab-org/gitlab-ce/issues/13838
shadeslayer 11y ago
Here you go https://gitlab.com/gitlab-org/gitlab-ce/issues/13840 https://gitlab.com/gitlab-org/gitlab-ce/issues/13840 Thanks for the quick reply :)
- jobvandervoort 11y ago
  Thanks! We'll follow up in the issue.

by sytse 11y ago

mintplant 11y ago

git has a default user agent that looks like git/2.0.0, so you could detect that and redirect. I believe this is how GitHub makes this work.

jacobvosmaer 11y ago

The git:// protocol requires its own daemon (which is bundled with Git) running on port 9418 https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols#The-Git-Protocol https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protoco... . The standard Git daemon is unsuitable for GitLab I think because of the way it manages access control. https://git-scm.com/book/en/v2/Git-on-the-Server-Git-Daemon https://git-scm.com/book/en/v2/Git-on-the-Server-Git-Daemon For this to work in GitLab we would need to find or write an alternative implementation of the protocol. Sounds like a lot of work to me when we already have decent HTTP clone access.

jacobvosmaer 11y ago
Hmm I was wrong, the current version of the built-in Git daemon has an --access-hook option so no problem there. https://github.com/git/git/blob/56f37fda511e1615dc6df86c68f3b841711a7828/daemon.c#L291 https://github.com/git/git/blob/56f37fda511e1615dc6df86c68f3... The question is then: how badly do people want this and how many admins out there are willing to poke an extra hole in their firewall just for this protocol.
- jacobvosmaer 11y ago
  https://gitlab.com/gitlab-org/gitlab-ce/issues/13838 https://gitlab.com/gitlab-org/gitlab-ce/issues/13838

shadeslayer 11y ago

Here you go https://gitlab.com/gitlab-org/gitlab-ce/issues/13840 https://gitlab.com/gitlab-org/gitlab-ce/issues/13840 Thanks for the quick reply :)

jobvandervoort 11y ago
Thanks! We'll follow up in the issue.