3 ms·

I just tried that in http://facebook.github.io/draft-js/ http://facebook.github.io/draft-js/, and Edit -> Undo worked for me.

ridiculous_fish 11y ago
Hmm, what were your steps where it worked? Undo and other text editing facilities aren't completely nonfunctional, they just become broken and unpredictable. For example, these steps: 1. Load http://facebook.github.io/draft-js/ http://facebook.github.io/draft-js/ 2. Click in the text box 3. Type 'hello' on the keyboard 4. Using the mouse, choose Edit -> Undo The text box will show "h" instead of being empty. Do you see this too? Note that cmd-Z won't reproduce this since the page tries to handle that itself to work around these bugs.
- danabramov 11y ago
  Good catch. Maybe worth filing an issue?
  - the_mitsuhiko 11y ago
    Against what? Html5? ;)
    - Reinmar 11y ago
      Well... yes :D [1] (AFAIR this case is covered by [2]). The Editing Task Force is working on opening necessary APIs so editor implementors could integrate with all the native features. I wrote an article about the effort [3]. It's a bit outdated now, but explains what are the goals. [1] https://github.com/w3c/editing/issues https://github.com/w3c/editing/issues [2] https://github.com/w3c/editing/issues/79 https://github.com/w3c/editing/issues/79 [3] https://medium.com/content-uneditable/fixing-contenteditable-1a9a5073c35d https://medium.com/content-uneditable/fixing-contenteditable...
eloisant 11y ago
It surely does, because it's a crucial feature for a text editor, but the developers had to implement and undo/redo stack in their lib. Anyway this approach is the only good one if you don't want to produce crappy HTML that will end up on your site. TinyMCE and the rest are obsolete, and editors like DraftJS or mobiledoc-kit are the only viable solutions until browsers offer a new, not broken alternative to content-editable.

ridiculous_fish 11y ago

Hmm, what were your steps where it worked? Undo and other text editing facilities aren't completely nonfunctional, they just become broken and unpredictable. For example, these steps: 1. Load http://facebook.github.io/draft-js/ http://facebook.github.io/draft-js/ 2. Click in the text box 3. Type 'hello' on the keyboard 4. Using the mouse, choose Edit -> Undo The text box will show "h" instead of being empty. Do you see this too? Note that cmd-Z won't reproduce this since the page tries to handle that itself to work around these bugs.

danabramov 11y ago
Good catch. Maybe worth filing an issue?
- the_mitsuhiko 11y ago
  Against what? Html5? ;)
  - Reinmar 11y ago
    Well... yes :D [1] (AFAIR this case is covered by [2]). The Editing Task Force is working on opening necessary APIs so editor implementors could integrate with all the native features. I wrote an article about the effort [3]. It's a bit outdated now, but explains what are the goals. [1] https://github.com/w3c/editing/issues https://github.com/w3c/editing/issues [2] https://github.com/w3c/editing/issues/79 https://github.com/w3c/editing/issues/79 [3] https://medium.com/content-uneditable/fixing-contenteditable-1a9a5073c35d https://medium.com/content-uneditable/fixing-contenteditable...

eloisant 11y ago

It surely does, because it's a crucial feature for a text editor, but the developers had to implement and undo/redo stack in their lib. Anyway this approach is the only good one if you don't want to produce crappy HTML that will end up on your site. TinyMCE and the rest are obsolete, and editors like DraftJS or mobiledoc-kit are the only viable solutions until browsers offer a new, not broken alternative to content-editable.