5 ms·
Kinda meh on adding it to the repo since it's yet another file I have to "manage" that isn't really part of the working code.
by swang 11y ago
Kinda meh on adding it to the repo since it's yet another file I have to "manage" that isn't really part of the working code.
- nvk 11y agoMany large FOSS projects (which this is aimed for) already have CONTRIBUTING.md etc... I personally prefer this non UI/Github specific approach.
- dhagz 11y agoI agree. This gives other git hosting providers the ability to implement the same feature using the same files.
- JBiserkov 11y agoYes. Yet it's a bit weird in case .github folder is used. Will they support a .bitbucket, .gitlab, etc. They could have used a more generic name like .contributing, but this increases the risk of name collision.
- sytse 11y agoWe plan to support both .github and .gitlab in GitLab https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2864 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2864
- zardeh 11y agoor like .dotfiles/ or .repoconfig/
- matheussampaio 11y agoThey can start with `.github` and later give us a way to define a custom name, like adding something on `.gitconfig` or `.gitattributes`.
- aidenn0 11y agoWould you seriously rather have it unversioned and untracked and managed with some random webpage on github?
- swang 11y agoUhm, yes I would rather not have it in my repo. As to whether or not I want it tracked/versioned, that is completely outside the workflow for versioning in code in a repo. You can maintain a "version" of this separately ala Wikipedia's edit history, or even just have a hidden separate git repo for these things if you must use git. They already have this with gists. With lint configs or npm configs you can argue that changes to those would affect code, which would require them to remain in sync. But what is the point of this new issue_template.md as part of the git repo? It's not as though there will be any significant time where a code change necessitates a change in how issue templates are made. This feels like a bad hack. Like they saw CONTRIBUTING.md and thought, "well might as well just keep going" and added issue/pr templates.
- icholy 11y agoI totally get where you're coming from. An extra file in your repository is quite the burden. This template file is the straw that broke the camels back. It should be removed. But why stop there? Let's also remove the README.md from the repo. It can also have it's own independent revision history. Maybe they should also add a feature for managing the LICENSE file for you. /sarcasm
- joshmanders 11y agoExcept that CONTRIBUTING.md and README.md and LICENSE are all typical files found in a repo that are independent of GitHub. If I push this repo to bitbucket or gitlab, the same stuff is just as important. But `issue_template.md` and `pull_request_template.md` is only dependent on github and is clutter in the repo. Sure if gitlab or bitbucket have these features and use those names, cool it translates to those services too. But it doesn't matter to the code itself. Ideally both of those files should be under a `templates` section in the repository settings tab.
- nzoschke 11y agoLiving guidelines on how to change the code is an incredibly important part of working code. I'm going to move this out of wikis and into SCM ASAP.
- JBiserkov 11y agoI agree. At least they made a way to separate GitHub stuff: >If you're worried about the added clutter in the root directory of your project, we also added support for a .github/ folder. You can put CONTRIBUTING.md , ISSUE_TEMPLATE.md , and PULL_REQUEST_TEMPLATE.md files in .github/ and everything will work as expected
- jrochkind1 11y agoWell, you certainly don't have to. If you haven't seen a need for it, no reason to start using it. I hope that all repos don't start using it just cause it's there.