3 ms·
1. What is the problem with this? Back links and everything else should still work. And it saves a lot of time. 2. I agree the user should be able to override a
by sytse 11y ago
1. What is the problem with this? Back links and everything else should still work. And it saves a lot of time.
2. I agree the user should be able to override and made https://gitlab.com/gitlab-org/gitlab-ce/issues/13436 https://gitlab.com/gitlab-org/gitlab-ce/issues/13436
3. Where do we do this?
4. I don't think infinite scrolling is always bad.
5. What do you suggest we do instead? PNG's for all icons are expensive to load.
- jhasse 11y ago1. No, "everything else" doesn't still work. You're reimplementing a browser in JavaScript! For example: There's no spinning loading indication on the left side of my tab. When clicking on a link and pressing back while it's loading, it doesn't abort, but goes back instead. 3. Do you mean the animation? You don't do this yet. 5. SVGs
- sytse 11y agoThanks for your feedback. 1. I agree that these browser functions are broken. I think the speedup is worth it but that is personal. BTW Turbolinks are a default feature of modern rails apps, doesn't mean they are right but they are common. 3. We don't plan to do this either as far as I'm aware. 5. Icons in SVG would be nicer but that looks like a lot of work.
- jhasse 11y agoI see. I have to say: Gitlab's support seems to be top-notch. I'm sorry for being a bit harsh and thanks for the kind response! :)
- jobvandervoort 11y agoNo worries, thanks for the feedback! To add to sytses: - We're introducing some more pagination over infinite scrolling. If we see this is successful, we might continue that trend - eventually we will replace the icons with svgs, probably when we switch to our inhouse icons. There is no due date for that, though.
- sytse 11y agoYou're welcome, and no problem about being harsh, feedback shows you care!