3 ms·
First off, I would really like to commend you for caring and responding to everyone on here. You deserve a lot of kudos for this! 'Test the merge' is something
by kaendfinger 11y ago
First off, I would really like to commend you for caring and responding to everyone on here. You deserve a lot of kudos for this!
'Test the merge' is something that we already get from GitHub. Travis CI tests both the merge and the branch itself. I think it only makes sense to test both, in fact, if I were to choose one way for a Merge Request, I would just test the merge result.
We have IoT Platform SDKs (See https://github.com/IOT-DSA/sdk-dslink-dart https://github.com/IOT-DSA/sdk-dslink-dart and https://github.com/IOT-DSA/sdk-dslink-java https://github.com/IOT-DSA/sdk-dslink-java for examples) that at somepoint I would like to pitch the idea to move from GitHub to GitLab fully. We currently utilize GitLab for only a portion of our projects. We find it really helpful that Travis CI tests both the merge result and the branch, and even though I could look over it to switch GitLab (because let's face it, GitLab > GitHub), I would love to be able to tell the other developers that they will only be gaining functionality.
As for the code analytics, I have second guessed myself, and I completely agree with you now. This is definitely something that I see most useful in the enterprise setting.
- sytse 11y agoThanks for your kind words. I was not aware that Travis CI tests both the branch and the merge, do you maybe have a link to the documentation for this? There are a couple of ways to implement this feature and we're discussing them in https://gitlab.com/gitlab-org/gitlab-ce/issues/4176 https://gitlab.com/gitlab-org/gitlab-ce/issues/4176 Feel free to join the conversation and/or contribute it. For now this feature is planned for 8.7 but this might change.
- kaendfinger 11y agoThanks. See https://docs.travis-ci.com/user/pull-requests#How-Pull-Requests-are-Tested https://docs.travis-ci.com/user/pull-requests#How-Pull-Reque... and http://cl.ly/3L303u2j072x/Image%202016-02-13%20at%207.17.57%20PM.png http://cl.ly/3L303u2j072x/Image%202016-02-13%20at%207.17.57%... for how Travis CI checks both.