3 ms·
Damn I knew GitLab was good but that article made it sound far more amazing than GitHub. I'm impressed. One thing I've really wanted was a voting system -> mer
by BinaryIdiot 11y ago
Damn I knew GitLab was good but that article made it sound far more amazing than GitHub. I'm impressed.
One thing I've really wanted was a voting system -> merge. Is there a way to require X amount of votes (in general or from specific in a specific group) which, once that is hit, allows the PR to be merged into master? Part of our typical code review workflow is requiring a specific amount of people to approve the PR before it goes in but it's basically the honor system right now and it would be really cool to turn that into some sort of rule.
- sytse 11y agoSounds cool to me. Consider creating an issue for it and please indicate if you're interested in contributing it.
- BinaryIdiot 11y agoDone. I'd love to work on it but I'd unlikely have any time to do so (at least in the near future). https://gitlab.com/gitlab-org/gitlab-ce/issues/13411 https://gitlab.com/gitlab-org/gitlab-ce/issues/13411
- sytse 11y agoNo problem, thanks for creating a feature proposal.