3 ms·

Show HN: PatchBin.com - Pastebin for patches + comments + code review.

45 points by antileet 17y ago

mcav 17y ago
I know horizontal space is tight, but it'd be nice if you could have 2 at-least-80-character-wide views (rather than hard-wrapping them at whatever they are now) when you have a wider screen. Looks good though.
- deleted 17y ago
  [deleted]
- thwarted 17y ago
  Agreed. 80 characters is the bare minimum for code viewing. The choice of 55, which this seems to be, is extremely odd considering it's designed to view diffs (which technically means 81 or 82 for the leading edit indicator chars).
- antileet 17y ago
  Thanks! I'm having a tough time with CSS right now. I hope to add a client-side way to detect when the screen is large enough and show 80 character wide views.
  - dimarco 17y ago
    $(window).width() will display the viewable width of the client in jQuery. and onResize will fire on <body> when the window is resized. (food for thought) I think this is a pretty neat idea. Often a coworker is working remotely and our boss has been begging for some code review. This could have some use.
antileet 17y ago
To the folks who tried out the commenting: A lot of comments are blank. If you entered valid text and that didn't get written to the database, and is a bug. Can you please describe any bad experience you had with the commenting system. Thanks!
- bloonlabs 17y ago
  You might want to put a "cancel" button on the comment form. The blank comments might be people who are trying to get rid of the comment form after accidentally double-clicking.
  - antileet 17y ago
    Done! Thanks!
- jestar_jokin 17y ago
  When creating a comment, don't pop up multiple comment entry boxes. Will you have logins and moderation etc to avoid spam?
oinopion 17y ago
XSS open. http://github.com/ninjagod/patchbin/issues#issue/1 http://github.com/ninjagod/patchbin/issues#issue/1
- antileet 17y ago
  I disabled escaping because it had trouble rendering XML code. I thought it was safe but I was wrong. Fixing now. Thanks! [edit] fixed
  - oinopion 17y ago
    I played a bit with code and I think you could benefit from reading: http://www.python.org/dev/peps/pep-0008/ http://www.python.org/dev/peps/pep-0008/ http://docs.djangoproject.com/en/dev/topics/forms/ http://docs.djangoproject.com/en/dev/topics/forms/ http://docs.djangoproject.com/en/dev/topics/db/models/#many-to-one-relationships http://docs.djangoproject.com/en/dev/topics/db/models/#many-...
thegoleffect 17y ago
I really like this implementation. Very clean, effective, and simple. I hope you continue to make progress on it ^_^.
woadwarrior01 17y ago
Nice. One minor nitpick, your django instance is running in DEBUG mode.

45 points by antileet 17y ago

mcav 17y ago

I know horizontal space is tight, but it'd be nice if you could have 2 at-least-80-character-wide views (rather than hard-wrapping them at whatever they are now) when you have a wider screen. Looks good though.

deleted 17y ago
[deleted]
thwarted 17y ago
Agreed. 80 characters is the bare minimum for code viewing. The choice of 55, which this seems to be, is extremely odd considering it's designed to view diffs (which technically means 81 or 82 for the leading edit indicator chars).
antileet 17y ago
Thanks! I'm having a tough time with CSS right now. I hope to add a client-side way to detect when the screen is large enough and show 80 character wide views.
- dimarco 17y ago
  $(window).width() will display the viewable width of the client in jQuery. and onResize will fire on <body> when the window is resized. (food for thought) I think this is a pretty neat idea. Often a coworker is working remotely and our boss has been begging for some code review. This could have some use.

antileet 17y ago

To the folks who tried out the commenting: A lot of comments are blank. If you entered valid text and that didn't get written to the database, and is a bug. Can you please describe any bad experience you had with the commenting system. Thanks!

bloonlabs 17y ago
You might want to put a "cancel" button on the comment form. The blank comments might be people who are trying to get rid of the comment form after accidentally double-clicking.
- antileet 17y ago
  Done! Thanks!
jestar_jokin 17y ago
When creating a comment, don't pop up multiple comment entry boxes. Will you have logins and moderation etc to avoid spam?

oinopion 17y ago

XSS open. http://github.com/ninjagod/patchbin/issues#issue/1 http://github.com/ninjagod/patchbin/issues#issue/1

antileet 17y ago
I disabled escaping because it had trouble rendering XML code. I thought it was safe but I was wrong. Fixing now. Thanks! [edit] fixed
- oinopion 17y ago
  I played a bit with code and I think you could benefit from reading: http://www.python.org/dev/peps/pep-0008/ http://www.python.org/dev/peps/pep-0008/ http://docs.djangoproject.com/en/dev/topics/forms/ http://docs.djangoproject.com/en/dev/topics/forms/ http://docs.djangoproject.com/en/dev/topics/db/models/#many-to-one-relationships http://docs.djangoproject.com/en/dev/topics/db/models/#many-...

thegoleffect 17y ago

I really like this implementation. Very clean, effective, and simple. I hope you continue to make progress on it ^_^.

woadwarrior01 17y ago

Nice. One minor nitpick, your django instance is running in DEBUG mode.