3 ms·
Cool tool! I run a GitHub code review app myself (https://reviewable.io https://reviewable.io) and have a similar feature built-in to customize the completion
by piotrkaminski 11y ago
Cool tool! I run a GitHub code review app myself (https://reviewable.io https://reviewable.io) and have a similar feature built-in to customize the completion condition: https://github.com/Reviewable/Reviewable/wiki/FAQ#can-i-customize-what-makes-a-review-complete https://github.com/Reviewable/Reviewable/wiki/FAQ#can-i-cust.... The main difference is that you took a declarative approach, which I contemplated but discarded after checking with my users and discovering how much variety there was in their approval algorithms. I'm running user scripts on AWS Lambda instead: http://blog.reviewable.io/your-code-my-app-no-worries http://blog.reviewable.io/your-code-my-app-no-worries.
I'll be curious to see how your project works out!
- davegaeddert 11y agoAwesome! I actually contemplated going that route as well, but obviously decided not to. Cool use for Lambda though. Do you find that people are using that feature?
- piotrkaminski 11y agoSome people are, but mostly just a hardcore few who are using protected branches on GitHub. I expect usage to tick up as I ramp up (in app) marketing for the feature and move upmarket into larger companies with more formal development workflows. But also, this was an investment in infrastructure that will allow me to offer other deep customizations later on.