5 ms·

https://github.com/brave/browser-ios https://github.com/brave/browser-ios "Firefox for iOS" They forgot to remove the branding from their "new" browser.

by rockdoe 11y ago

m52go 11y ago
It's not a mistake. Firefox is referenced throughout the documentation. Looks like Brave is built on top of it.
- rockdoe 11y ago
  Venturebeat claims it's based on Chromium, but they also seem to be pretty confused because they're calling it "a brand new browser, because (builing on top of existing browsers) would imply limited functionality by virtue of their application programming interfaces (APIs) and less impressive performance gains" http://venturebeat.com/2016/01/20/brave-browser/ http://venturebeat.com/2016/01/20/brave-browser/ So it's Chrome on Desktop, Firefox for iOS on iOS?
  - reubenmorais 11y ago
    It's based on GitHub's Electron (Chromium) on desktop, and Firefox for iOS on iOS: http://www.brianbondy.com/blog/172/brave-software http://www.brianbondy.com/blog/172/brave-software
  - ainar-g 11y ago
    Firefox on iOS is built with WebKit, not Gecko [1]. IIRC, it's because Apple doesn't like engines that are not WebKit. Chromium uses Blink, which is a fork of WebKit, so Firefox for iOS and Chromium are relatives in a sense. [1] https://en.wikipedia.org/wiki/Firefox_for_iOS https://en.wikipedia.org/wiki/Firefox_for_iOS.
- sp332 11y ago
  Mozilla is very protective of their trademark though. You're supposed to replace their branding with your own before distributing your modified code.
  - reubenmorais 11y ago
    You're supposed to remove the branding from the binary — as in user visible logos and names —, not the source code. You can't reasonably expect forks to remove all the thousands of references to "Firefox" from the source code, like in comments, component names, etc.
    - GFK_of_xmaspast 11y ago
      https://en.wikipedia.org/wiki/Sed https://en.wikipedia.org/wiki/Sed
      - reubenmorais 11y ago
        Yeah, but it'd be a silly requirement, and would make syncing upstream changes to your fork needlessly difficult. My point is the Firefox branding stuff does not apply to the source code of forks.
      - chris_wot 11y ago
        Oh yeah, that would be really easy.
        GFK_of_xmaspast 11y ago
        https://en.wikipedia.org/wiki/Find https://en.wikipedia.org/wiki/Find
        chris_wot 11y ago
        Digging that hole deeper and deeper there I see.
manyoso 11y ago
And the laptop version (windows, macosx, linux) seems to be based on Chromium and Node.js.
bobajeff 11y ago
"Link Bubble Browser" Is the base for the Android version. It sounds like the whole idea is to add bitcoin micropayments to the web and stop (via blockers) sites from using heavy intrusive ads.

https://github.com/brave/browser-ios https://github.com/brave/browser-ios "Firefox for iOS" They forgot to remove the branding from their "new" browser.

by rockdoe 11y ago

https://github.com/brave/browser-ios https://github.com/brave/browser-ios "Firefox for iOS" They forgot to remove the branding from their "new" browser.

m52go 11y ago

It's not a mistake. Firefox is referenced throughout the documentation. Looks like Brave is built on top of it.

rockdoe 11y ago
Venturebeat claims it's based on Chromium, but they also seem to be pretty confused because they're calling it "a brand new browser, because (builing on top of existing browsers) would imply limited functionality by virtue of their application programming interfaces (APIs) and less impressive performance gains" http://venturebeat.com/2016/01/20/brave-browser/ http://venturebeat.com/2016/01/20/brave-browser/ So it's Chrome on Desktop, Firefox for iOS on iOS?
- reubenmorais 11y ago
  It's based on GitHub's Electron (Chromium) on desktop, and Firefox for iOS on iOS: http://www.brianbondy.com/blog/172/brave-software http://www.brianbondy.com/blog/172/brave-software
- ainar-g 11y ago
  Firefox on iOS is built with WebKit, not Gecko [1]. IIRC, it's because Apple doesn't like engines that are not WebKit. Chromium uses Blink, which is a fork of WebKit, so Firefox for iOS and Chromium are relatives in a sense. [1] https://en.wikipedia.org/wiki/Firefox_for_iOS https://en.wikipedia.org/wiki/Firefox_for_iOS.
sp332 11y ago
Mozilla is very protective of their trademark though. You're supposed to replace their branding with your own before distributing your modified code.
- reubenmorais 11y ago
  You're supposed to remove the branding from the binary — as in user visible logos and names —, not the source code. You can't reasonably expect forks to remove all the thousands of references to "Firefox" from the source code, like in comments, component names, etc.
  - GFK_of_xmaspast 11y ago
    https://en.wikipedia.org/wiki/Sed https://en.wikipedia.org/wiki/Sed
    - reubenmorais 11y ago
      Yeah, but it'd be a silly requirement, and would make syncing upstream changes to your fork needlessly difficult. My point is the Firefox branding stuff does not apply to the source code of forks.
    - chris_wot 11y ago
      Oh yeah, that would be really easy.
      - GFK_of_xmaspast 11y ago
        https://en.wikipedia.org/wiki/Find https://en.wikipedia.org/wiki/Find
        chris_wot 11y ago
        Digging that hole deeper and deeper there I see.

manyoso 11y ago

And the laptop version (windows, macosx, linux) seems to be based on Chromium and Node.js.

bobajeff 11y ago

"Link Bubble Browser" Is the base for the Android version. It sounds like the whole idea is to add bitcoin micropayments to the web and stop (via blockers) sites from using heavy intrusive ads.