3 ms·
Hi, we decided to make it easy to setup the tool and run it. The source code is available on GitHub https://github.com/PatchworkSecurity/cleansweep/blob/master
by dchanm 11y ago
Hi, we decided to make it easy to setup the tool and run it. The source code is available on GitHub
https://github.com/PatchworkSecurity/cleansweep/blob/master/clients/shell/cleansweep.sh https://github.com/PatchworkSecurity/cleansweep/blob/master/...
The comments explain what is happening at each step.
- DoubleMalt 11y agoWould you bet you live on the assumptionthat there is no way a network problem could truncate the script into something, that does something unintended but harmful? http://www.seancassidy.me/dont-pipe-to-your-shell.html http://www.seancassidy.me/dont-pipe-to-your-shell.html
- kentonv 11y agoThat problem is easily avoided by wrapping the whole script in a function and then calling it on the last line. It looks like Patchwork's script doesn't quite do that, but it does put _most_ of its functionality into functions, and AFAICT there is no particular place in the script where a connection loss could lead to anything bad happening. Admittedly this appears to be a lucky accident rather than following best practice.
- dchanm 11y agoHi DoubleMalt, Thanks for the link. I've filed an issue and should have this fixed tonight https://github.com/PatchworkSecurity/cleansweep/issues/7 https://github.com/PatchworkSecurity/cleansweep/issues/7