4 ms·
> I don't know, perhaps sails is riddled with unfixed bugs? I wrote about a fair amount of unexpected behavior with Sails/Waterline. Some of these have since b
by kevinburke 11y ago
> I don't know, perhaps sails is riddled with unfixed bugs?
I wrote about a fair amount of unexpected behavior with Sails/Waterline. Some of these have since been fixed, some of them (Waterline defaults to dropping tables unless you have NODE_ENV=production in an env var) are deliberate decisions and hence not "fixable". https://kev.inburke.com/kevin/dont-use-sails-or-waterline/ https://kev.inburke.com/kevin/dont-use-sails-or-waterline/
There's a fair amount of other stuff I would hope to change and that we've just ripped out of our fork.
- If count() isn't implemented in an adapter Waterline will fetch the entire table into memory to count the number of rows.
- Sails by default creates a route for every function in a controller, which makes it easy for an attacker to bypass policies
- blueprints routinely 500 server error based on user input
- https://github.com/balderdashy/waterline/issues/1248 https://github.com/balderdashy/waterline/issues/1248
- All SELECT queries on text fields call LOWER() before matching, so all of your indexes also have to match this
- There's a batch insert interface but N connections are established to insert N records... if one of the inserts fails, the behavior of the other inserts is not guaranteed
After the ugly discussion at the OP's link we decided to fork Sails and Waterline and rip out all of the stuff we don't need. I wrote about that here: https://kev.inburke.com/kevin/safely-moving-a-large-shrinkwrapped-dependency/ https://kev.inburke.com/kevin/safely-moving-a-large-shrinkwr...
- jakejake 11y agoSounds like at least a few of those are legit concerns, if not bugs. Like I said, I don't really know much about Sails. I was just interested in the idea that ~10 commits per month would be insinuated to be an abandoned project.
- traviswebb 11y agoIf you only knew how much work needs to be done on Sails.js, you'd understand how inadequate 10 commits per month is :)
- hitekker 11y agoDepends on the kind of projects. In the "heavy" web framework category ("we take care of lots of the busy work for you"), an established project like Django can expect 256 commits a month: https://github.com/django/django/pulse/monthly https://github.com/django/django/pulse/monthly. For rails, 468: https://github.com/rails/rails/pulse/monthly https://github.com/rails/rails/pulse/monthly ExpressJS, on the other hand, only had 5 commits this past month, but one could argue that it's not as "heavy" as SailsJS and others are trying to be. I agree commit count by itself is not a good pulse on a project's life, but, as this thread shows, there's a lot of issues left unresolved. Not mentioned yet one of the lead developers posted on Sails.js future right here: https://www.reddit.com/r/node/comments/2p2i40/is_sailsjs_dead_dying/cmu0sj9 https://www.reddit.com/r/node/comments/2p2i40/is_sailsjs_dea... The most important line is: > There's not much really left to add to Sails other than bug fixes at this point. All these indicators together = a dead project.
- kyllo 11y ago- There's a batch insert interface but N connections are established to insert N records... if one of the inserts fails, the behavior of the other inserts is not guaranteed Whoa, that is bad. If you don't understand what a transaction is, you have no business writing a database library.