4 ms·
A quick 30s scan of the webhooks docs looks like that is correct; if you used e.g. 12345 as your secret, you would be susceptible to a dictionary attack from an
by aidenn0 11y ago
A quick 30s scan of the webhooks docs looks like that is correct; if you used e.g. 12345 as your secret, you would be susceptible to a dictionary attack from anybody who was able to record a message, on the order of 10s of billions of keys per second can be tested with a multi-GPU setup.
I suspect that the web hooks typically run over TLS, so recording the plaintext of a request would be a challenge in and of itself.
- KirinDave 11y agoIf your shared secret is vulnerable to brute forcing, it's vulnerable to brute forcing. An easy fix for this: generate your shared secret by hashing or salthashing a low-entropy password. As a general rule though, HMAC is used with randomly generated secrets. I don't know why GitHub doesn't just tell you the secret. Amazon's implementation is much more correct.