3 ms·
Interesting. What do you like about code review things? I personally found it to be lacking. It's hard to dig up comments on branches that have been merged into
by btmiller 11y ago
Interesting. What do you like about code review things? I personally found it to be lacking. It's hard to dig up comments on branches that have been merged into a master branch and I'd also like to have notes/comments on the HEAD of a project. Right now, they just get perpetually buried. That's where a lot of project decisions end up getting made in my team.
Perhaps we should be using a wiki or some other system, but I'd really love for some more enhancements to code review.
- tedmiston 11y agoI agree with you on finding branch comments post-merge. I found using merge requests makes it easier, but to be honest, I don't look at comments much after the fact. Making more small branches with merge requests was really helpful for us. As far as commenting on HEAD, I think they've intentionally avoided that given how fast it could change and not having a deterministic way to anchoring comments to the correct lines. Related: Tom Lehman from Genius explains some of the problems of fuzzy annotation anchoring in a 10-min video: https://www.youtube.com/watch?v=FJyqfRcyYIQ https://www.youtube.com/watch?v=FJyqfRcyYIQ.