3 ms·
I currently have the role of the lead reviewer you describe and I often worry I'm focusing too much on minor details. Fortunately my coworkers are comfortable p
by cjcenizal 11y ago
I currently have the role of the lead reviewer you describe and I often worry I'm focusing too much on minor details. Fortunately my coworkers are comfortable pushing back. I think if you're able to have an objective discussion and agree on your goals, and whether a suggested change meets them better than the existing code, you'll be able to get work done together without one of you feeling like you're being a problem. The reviewer also has to be prepared to let go of a suggestion if the change won't have an actual impact.
- freditup 11y agoIt's a tough issue. Having every line of code be exactly 100% consistent isn't a bad thing, in fact, it's a good thing. But, I question if it's worth the time, effort and frustration to do this. I feel it could be better spent on more pragmatic things, like code correctness. And then of course, there's the minor changes that don't actually bring any improvement at all. It's tough though, because I feel that pushing back against these things, at least in the short term, just eats more time, is more of an effort, and causes tension.