7 ms·
New Fn() vs. Object.create(P)
- TazeTSchnitzel 11y agoI like how this page uses ASCII diagrams converted into fancy graphical ones on-the-fly! Looks like it's done with Shaky, which has been on HN before: http://shaky.github.bushong.net/ http://shaky.github.bushong.net/ Really neat tool.
- leeoniya 11y agoI'd say somewhat impractical since one can scribble those diagrams in MSPaint much faster than making them in ASCII first. I'd actually find the opposite direction much more useful. http://asciiflow.com/ http://asciiflow.com/ might be helpful otherwise.
- magicalist 11y ago> I'd say somewhat impractical since one can scribble those diagrams in MSPaint much faster than making them in ASCII first ...until you want to tweak the layout of an almost completed diagram slightly, and now you hate life. For a particular type of diagram (notably there are very few options, and the more options you add the closer you are to needing a full diagram editing program (like asciiflow) instead of a text file) this is a great productivity booster.
- whoopdedo 11y agoWhy are you drawing vectors in a bitmap editor? LibreOffice Draw is simple enough to use and has most diagram shapes built-in.
- magicalist 11y agomrale.ph blog post on writing Shaky: http://mrale.ph/blog/2012/11/25/shaky-diagramming.html http://mrale.ph/blog/2012/11/25/shaky-diagramming.html (weirdly the only source for it he released that I can find is buried in another git repo: https://github.com/mraleph/moe-js/tree/master/talks/jsconfeu2012/tools/shaky https://github.com/mraleph/moe-js/tree/master/talks/jsconfeu...)
- mraleph 11y agoIt was originally written for the jsconf talk and since has always been sitting in that repo. I was planning to move it out - but never got to it.
- mraleph 11y agoIt's done with my original Dart version of Shaky. The CoffeScript version is a port of the Dart version. You can also notice that http://shaky.github.bushong.net/ http://shaky.github.bushong.net/ does not support certain additional features that the post uses, e.g. it does not render curly brace or wavy "~~~~~" break line from the: +-------+ | 1 +-+ +-------+ | | 2 | | +-------+ > N slots reserved for in-object properties ~~~~~~~~~ | +-------+ | | N +-+ +-------+
- TheAceOfHearts 11y agoMight wanna add 2014 to the title? Now that we have ES2015, I wonder if there's any performance difference between using a function and a class, even though class is "just sugar" over prototypes.
- noobermin 11y agoA relevant question is whether the newest version of v8 is any better than it was a year ago with respect to these issues.
- mraleph 11y agoES2015 class does not provide you with a way to declare instance fields. You still create them imperatively in the constructor. Which means for the purposes of the post ES2015 classes are not different from standalone constructor functions - as VM still has to figure out optimal layout dynamically.
- TazeTSchnitzel 11y agoThis structure looked familiar to me: +-------+ | *---+-> hidden class (aka map) +-------+ | *---+-> out-of-object properties storage +-------+ | *---+-> elements storage +-------+ | 1 +-+ +-------+ | | 2 | | +-------+ > N slots reserved for in-object properties ~~~~~~~~~ | +-------+ | | N +-+ +-------+ That's because it's very close to PHP 7's implementation of objects (PHP has "traditional" class-based OOP): zend_object: +-------------+-------------+------------+-----------------------------------------+ | gc_info | flags | IS_OBJECT | refcount (32-bit) | +-------------+-------------+------------+-----------------------------------------+ | UNUSED (32-bit) | handle (32-bit) FIXME | +----------------------------------------+-----------------------------------------+ | ce - pointer to zend_class_entry (64-bit or 32-bit) | +----------------------------------------------------------------------------------+ | handlers - pointer to object handlers (64-bit or 32-bit) | +----------------------------------------------------------------------------------+ | properties - pointer to HashTable of dynamic properties (64-bit or 32-bit) | +----------------------------------------------------------------------------------+ | guards - pointer to HashTable used for recursion protection (64-bit or 32-bit) | +----------------------------------------------------------------------------------+ | properties_table[0] - embedded cell of the first declared property (128-bit) | +----------------------------------------------------------------------------------+ | ... | +----------------------------------------------------------------------------------+ | properties_table[N] - embedded cell of the last declared property (128-bit) | +----------------------------------------------------------------------------------+ | optional user data of internal classes (variable size) | +----------------------------------------------------------------------------------+ 63 48 47 40 39 32 31 0 (source: https://wiki.php.net/phpng-int#is_object https://wiki.php.net/phpng-int#is_object) PHP 7 objects contain N slots for properties defined in the class, plus a hashtable for any additional properties, just like V8 objects. I guess it's an obvious way to design it.
- mraleph 11y ago
- deleted 11y ago[deleted]
- swang 11y agoHi mraleph, if you're still reading this thread, how are you getting these result? Is worrying about this for normal web apps just a micro-optimization or can you see instances where this would affect an application's speed significantly?
- mraleph 11y ago> Is worrying about this for normal web apps just a micro-optimization or can you see instances where this would affect an application's speed significantly? I don't think there is such thing as an average web application so things must be decided on the case-by-case basis. In general if creation/usage of some "class" of objects is on the very hot path - then their layout can affect performance of the hot path. In this case constructor might be preferable for the reasons outlined in the post (faster construction, one less indirection for the property access). However the decision must be made only after deep investigation.
- senotrusov 11y agoTrying to understand the described matter I created some simple code to benchmark different cases. Probably I got something wrong, but setting properties inside the constructor function (prop-benchmark-b.js) are almost 6 times slower that setting them outside of it (prop-benchmark-a.js) https://gist.github.com/senotrusov/597514c773089b6989c6 https://gist.github.com/senotrusov/597514c773089b6989c6 What do you think, why I got such a different numbers? Thank you!
- mraleph 11y agoThere is a bug in your code: var o = new F(i, i, i, i, i, i, i, i, i, i, z) z = o // ... skipped o.z = z This makes o.z = o, so only the last object survives. When you use constructor you actually link all of them together - which means there is more garbage around - GCs are more expensive. If you fix this bug, e.g. by doing var o = new F(i, i, i, i, i, i, i, i, i, i, z) o.z = z z = o you actually OOM in prop-benchmark-a.js case because object there is less compact than one created by constructor. Just as the post predicts.
- jtwebman 11y agoWhat if you just did it more of the functional way. Have an object for state that is passed in for each function. Then Object.create isn't so bad. Just an idea as I found this pattern easier to maintain though I still use new.