4 ms·

Nobody will try to pull that shit again for quite some time. The "Constructive" version will be handwaved by submitting the same code again and giving literall

by x1024 11y ago

Nobody will try to pull that shit again for quite some time. The "Constructive" version will be handwaved by submitting the same code again and giving literally any deflecting excuse like "You're just afraid of using new technology like this function.

mikeash 11y ago
"We should be careful to get out of an experience only the wisdom that is in it and stop there lest we be like the cat that sits down on a hot stove lid. She will never sit down on a hot stove lid again and that is well but also she will never sit down on a cold one anymore." The lesson a lot of people are going to learn from this is, "Don't submit any code to Linux." Not submitting code like this is merely going to be a small side effect. Especially since Linus doesn't explain his reasoning so there's no real way to know if the next chunk of code is going to displease him or not.
- marrs 11y ago
  The lesson a lot of people are going to learn from this is, "Don't submit any code to Linux." That's true, but not really a problem. Linux is one of the most popular open source projects out there.
  - mikeash 11y ago
    It's still a problem if you want to keep it that way, or if you value quality over quantity.
    - marrs 11y ago
      But the shouting is intended to maintain quality. I appreciate that you doubt it does this. You could be right, but the article doesn't convince me of this. It seems to have a different agenda anyway, that the shouting is unacceptable regardless of any benefit. I'm not sure I go along with that either.
Kristine1975 11y ago
>Nobody will try to pull that shit again for quite some time. Watch me! (not really, but if I wanted to troll Linus, rants like that would serve as encouragement) Also using the compiler builtins is the most secure, most readable, least error-prone and fastest way of implementing overflow checks.
- x1024 11y ago
  Linus's rant is literally entirely based only on why that is wrong.
  - Kristine1975 11y ago
    He makes a lot of claims without backing any of them up.
    - x1024 11y ago
      Are you saying that the claim that the new function "is nonstandard" is false?
      - Kristine1975 11y ago
        No, he's right about that. But it's a red herring: The Linux kernel already uses a lot of GCC-specific, i.e. nonstandard, extensions.
kristiandupont 11y ago
>pull that shit Right, in fact, if I were the developer who wrote that shit, I would probably think twice about doing any work on the code. Not because I was insulted but because I would be scared. I don't know about this specific situation and maybe it's political/religious. But maybe the girl/guy just wrote this code because they thought it was the best solution. Being screamed at by an authority like that (even if they don't mention you by name) would be quite demoralizing to me. But I guess you can argue that I just don't have what it takes to be a Linux contributor then..
- x1024 11y ago
  I would argue exactly that, yes. If you don't understand basic things about code clarity and safety, you're not ready. The Linux Kernel doesn't exist to validate your opinion of yourself, but to literally support the world's software infrastructure. Which is more important.
  - deleted 11y ago
    [deleted]
enneff 11y ago
> Nobody will try to pull that shit again for quite some time. Did you read the thread? The programmer who wrote the original patch is arguing with him, just as he would have had Linus' reply been polite. I seems that vitriol does not have the power you think it does.

by x1024 11y ago

mikeash 11y ago

"We should be careful to get out of an experience only the wisdom that is in it and stop there lest we be like the cat that sits down on a hot stove lid. She will never sit down on a hot stove lid again and that is well but also she will never sit down on a cold one anymore." The lesson a lot of people are going to learn from this is, "Don't submit any code to Linux." Not submitting code like this is merely going to be a small side effect. Especially since Linus doesn't explain his reasoning so there's no real way to know if the next chunk of code is going to displease him or not.

marrs 11y ago
The lesson a lot of people are going to learn from this is, "Don't submit any code to Linux." That's true, but not really a problem. Linux is one of the most popular open source projects out there.
- mikeash 11y ago
  It's still a problem if you want to keep it that way, or if you value quality over quantity.
  - marrs 11y ago
    But the shouting is intended to maintain quality. I appreciate that you doubt it does this. You could be right, but the article doesn't convince me of this. It seems to have a different agenda anyway, that the shouting is unacceptable regardless of any benefit. I'm not sure I go along with that either.

Kristine1975 11y ago

>Nobody will try to pull that shit again for quite some time. Watch me! (not really, but if I wanted to troll Linus, rants like that would serve as encouragement) Also using the compiler builtins is the most secure, most readable, least error-prone and fastest way of implementing overflow checks.

x1024 11y ago
Linus's rant is literally entirely based only on why that is wrong.
- Kristine1975 11y ago
  He makes a lot of claims without backing any of them up.
  - x1024 11y ago
    Are you saying that the claim that the new function "is nonstandard" is false?
    - Kristine1975 11y ago
      No, he's right about that. But it's a red herring: The Linux kernel already uses a lot of GCC-specific, i.e. nonstandard, extensions.

kristiandupont 11y ago

>pull that shit Right, in fact, if I were the developer who wrote that shit, I would probably think twice about doing any work on the code. Not because I was insulted but because I would be scared. I don't know about this specific situation and maybe it's political/religious. But maybe the girl/guy just wrote this code because they thought it was the best solution. Being screamed at by an authority like that (even if they don't mention you by name) would be quite demoralizing to me. But I guess you can argue that I just don't have what it takes to be a Linux contributor then..

x1024 11y ago
I would argue exactly that, yes. If you don't understand basic things about code clarity and safety, you're not ready. The Linux Kernel doesn't exist to validate your opinion of yourself, but to literally support the world's software infrastructure. Which is more important.
- deleted 11y ago
  [deleted]

enneff 11y ago

> Nobody will try to pull that shit again for quite some time. Did you read the thread? The programmer who wrote the original patch is arguing with him, just as he would have had Linus' reply been polite. I seems that vitriol does not have the power you think it does.