5 ms·
I thought that finally I can see example of Linus being abusive. This was not it. Linus was attacking the work and ideas and cursing them. He was not attacki
by nabla9 11y ago
I thought that finally I can see example of Linus being abusive. This was not it.
Linus was attacking the work and ideas and cursing them. He was not attacking the person who wrote the code. Cursing is not abusive by itself. Cursing is emotional emphasis.
I would not want to work in a environment where strong emotional language used to criticize your work is considered abusive. If conflict over ideas and work does not make your blood flow, you don't care.
- Cyph0n 11y agoBut do you not feel offended when you are the one who came up with the idea?
- x1024 11y agoThey... should be offended? Because it was a bad idea that ruins the Linux Kernel. Kernel development isn't for everyone.
- tptacek 11y agoCan you (the person who wrote that this code would "ruin" the Linux kernel) explain in as much detail as you can how it would have ruined the Linux kernel? I'm curious about how much people take what Linus says at face value.
- x1024 11y agoCode being safe or unsafe is a pretty objective metric of quality, methinks.
- tptacek 11y agoI agree. Can you explain how this particular code is "safe" or "unsafe"? Again: I'm curious as to how much of what Linus says is taken at face value on HN. I'm even more interested now, because the fulcrum of Linus's argument isn't safety.
- x1024 11y agoYou are committing a logical fallacy. I'm not "the voice of HN", nor am I a representative sample of "what HN thinks". This is just my opinion. Using a builtin operation ("addition and comparison of integers") is always safer than using a function that may or may not work the same everywhere. I.e. a nonstandard function. Also, the proposed code has more levels of indirection, therefore places a higher cognitive load on the reader. These things tend to result in bugs down the road. And it is also true that "an overflow could still happen", which is mentioned in Linus' critique. All of these are objective ways to measure how "safe" the code is.
- tptacek 11y agoNo, that's not what Linus is saying. It's close to the opposite of what he's saying (overflow_usub wraps a builtin). You obviously can't simply use the builtin addition and subtraction of unsigned integers in safe code, because in modern C, integers wrap. Returning to the thread: why are you so comfortable extrapolating from Linus's rant to "this code would ruin the Linux kernel"? You don't grok the code he's talking about. Is it because "if Linus is arguing against this code with this much ferocity, the code must be really bad?" Because if that's it, you're starting to see the issue some people have with the tone he uses.
- x1024 11y agoIn the discussion Linus is providing his suggested code, which is literally "just a builtin addition", but your opinion is that "He says that you can't use builtin addition". OK, sure.
- tptacek 11y agoThat is not in fact what Linus is saying. At this point you might want to take my word for it.
- deleted 11y ago[deleted]
- deleted 11y ago
- Cyph0n 11y agoI was referring to OP's general opinion.
- ceejayoz 11y ago> Because it was a bad idea that ruins the Linux Kernel. That seems a bit hyperbolic. > Kernel development isn't for everyone. Very little is "for everyone". That's not an excuse to offer criticism in a nasty manner. The article links to a nicer response that's a) shorter and b) a lot more likely to educate and build up a better contributor.
- cholantesh 11y agoI'd go even further - kernel development isn't just 'not for everyone', it's for very few. Relatively speaking, how many people are competent enough to contribute to the kernel? Those that even make the attempt are doing so voluntarily - if the reward from that is to be entreated with a hyperbolic rant, why would they bother going any further?
- tptacek 11y agoYou all realize that this argument cuts both ways, and probably even cuts against Linus harder, right? By the time Linus is ranting at someone at LKML, the person he's ranting at has --- statistically, at least --- already qualified themselves as especially competent. These people aren't arguing over Rails template languages. I'm coming to realize that the sociology of Linus LKML rants is pretty fascinating.
- GeoffreyP 11y agoNon-attachment, experience, maturity, and a host of other techniques.
- Kristine1975 11y agoBut then I don't care, according to the GP...
- nabla9 11y agoI would feel strong negative emotions for sure. That would be fine. I want to feel emotions and be challenged. I would be extremely motivated to prove Linus wrong. If I would realize I was wrong, I would lick my wounds and be hurt. The hurt felt would be related to the amount of work and effort I would have invested. I would not claim that Linus is responsible for my emotional state. I was challenged and I lost. Identifying with your ideas is fine in moderation but taking lasting personal offense is when your ideas forcefully rejected is madness.
- delinka 11y ago"He was not attacking the person who wrote the code." Linus: "...anybody who thinks that the above is [acceptable] is just incompetent and out to lunch." That's a direct attack on the coder (and anyone else who thought the code was acceptable.) The remainder of the rant is written in such as way as to castigate the coder indirectly by insulting the work. If that wasn't the intent, such emotional and abusive language is completely unnecessary to get the point across. I would not want to work in an environment where strong emotional language used to criticize employees "work" is considered acceptable.
- david-given 11y agoI would not want to work in an environment where strong emotional language used to criticize your work is not considered abusive. It's childish and counterproductive. I'm not your enemy, I'm your ally --- making me hate you isn't going to make me want to work with you. If I'm wrong, say so, but do it politely. I work with someone who has an amazing ability to tell people they're wrong and make them feel good about themselves. You come out of gruelling code reviews feeling hyped and enthusiastic about refactoring your code. It's a skill I'm not very good at and one I want to learn. That's professionalism in action.
- anonbanker 11y agoAnd we can see your net contributions to the kernel source tree as an example of the environment you choose to work in. but thank you for telling us your opinion anyway.
- dillera 11y agothis
- anonbanker 11y agoPlease don't make posts like this on HN. As bad as the SJW's are, I'd say "replying as upvote" kills the signal-to-noise ratio much more. I'm totally glad you agree with me (and thank you for taking the karma hit to post), but upvoting is enough to stave off the hoarde of downvoters. However, for anyone taking notice, "this'ing" a post is a great way to encourage parent downvotes, which is a far easier way to divebomb an opinion. Let's see if it becomes a tactic used in the future on HN.
- dang 11y agoPlease don't post uncivil comments to HN.
- anonbanker 11y agoI'm normally pretty good with your moderation. This one's a little vague. I worry that if I apply this uniformly, it'll effectively ban snark from my postings. I'll do my best to honor your request, though.
- norea-armozel 11y agoBut it wasn't clear what was wrong with it Linus' version of the criticism as opposed to the rewritten version which cut to the chase about the irregular usage of the helper function.
- enneff 11y ago> "Get rid of it. And I don't ever want to see that shit again." Would you really want to work with someone who speaks to you this way? It's like a caricature of a typical "evil boss". I'm amazed that Linus can take himself seriously writing like this. It's just so unnecessary and overly dramatic, like a child throwing a tantrum.
- MacsHeadroom 11y ago> He was not attacking the person who wrote the code. "No sane PERSON" "YOU damn well didn't do the right thing to begin with" "[YOU are] just incompetent and out to lunch" "[YOU] are so far out to lunch that it's not even funny" The lines above would suggest otherwise. (Capital emphasis mine.)
- tptacek 11y agoI think you might be confusing two different things. Is this the worst Linus rant ever? No. I think its virality is a bit inexplicable too. For a Linus rant, it is unusually focused on the code and not the upbringing of the authors of the code. It's weird that this is the one everyone's glomming onto; Gizmodo even ran a story headlined "you don't need to be a programmer to understand what this rant is about", but as you can see from this thread, even programmers don't understand what this rant is actually about. But "not the worst Linus rant ever" is not the same thing as "not abusive". This clearly is abusive language, and would not be tolerated in most professional teams, even if the rant was about something more substantial than the relatively insubstantial thing it's about.
- nabla9 11y agoSee my other comment: https://news.ycombinator.com/item?id=10506823 https://news.ycombinator.com/item?id=10506823 I suspect that this is generational/cultural issue. Abusive is codified and differentiation between "abusive language" and actual abuse is lost from people. >This clearly is abusive language, and would not be tolerated in most professional teams, Assuming that some people can differentiate between "abusive language" and actual abuse, is it possible to have different work cultures? Some are more masculine and competitive, some are more feminine and people select the work environment they like.
- tptacek 11y agoAn argument over the semantics of the word "abuse" will be unproductive. It's just abusive in a technical sense. I think on most well-managed teams in the US software industry, if you were a staff programmer, you could get away with a rant like this just once; you'd be warned, and if you did it again, you'd be dismissed. Obviously, if you were the manager, you could rant like this as much as you wanted. But then that's the point, right? Even on a team managed by a raving asshole, if you were lower-status and tried to get away with a rant like this, you'd get in trouble. I'm pretty sensitive to it because candidly it's a struggle for me not to be ranty like this particular Linus rant (thankfully, I am nowhere nearly as bad as the worst Linus rants) and I've had to work hard to suppress it.