3 ms·
> "Consider this replacement:" Those aren't weasel words, that's direct feedback. The rewritten message clearly indicates a rejection of the submitted code, s
by oxryly1 11y ago
> "Consider this replacement:"
Those aren't weasel words, that's direct feedback.
The rewritten message clearly indicates a rejection of the submitted code, so directing the submitter to consider the example replacement seems a constructive and appropriate response.
The rewritten version neglects the criticism that the submitted code is too fiddly relying on the short-circuit of the || operator, but Linus failed to mention that as well :p
- fnordfnordfnord 11y agoI disagree. "Consider this replacement" is practically an invitation to debate; or worse, possibly misunderstood as "I agree your way works, but I like my way better, so let me be capricious about it and reject your PR because I can." Another poster re-rewrote it in a way that I feel is at least unambiguous.
- chris_wot 11y agoThere has already been some comments on that message. Unless you are saying Linus is always correct? Or should people be fearful and not want to say anything at all to him? Looks a bit that way.
- oxryly1 11y agoMaybe. But imagine if Captain Jean-Luc Picard said it to you as a direct order. You'd probably get busy considering.
- chris_wot 11y agoI'm a nerd, so sue me. I'd rather have the order from Captain Janeway.
- klagermkii 11y agoEven if you don't consider them to be weasel words, it loses all emotional dynamic range that conveys the relative seriousness of the issue. When Linus is already limited in his communication with contributers by the nature of email, how does he separate minor problems from major ones? That rewritten post reads like it could be for a small stylistic mistake of relative unimportance. These "Linus rants" come up rarely enough that we're able to flag what is important to him (such as don't break user-space) from the thousands of other disagreements he has with contributers.