8 ms·
Linus meltdown on a Git pull
- SHIT_TALKER 11y agoTime for the quarterly "Linus said mean things to someone" post already?
- moonchrome 11y ago> sh.t ... f.cking Self censoring the swear words - how civil :D Asserting dominance with aggressive behavior is fine I guess (with in boundaries) - it makes calling out someone much more powerful but at the same time makes you look like a tool if you're wrong and you lose respect faster - double edged sword.
- ageofwant 11y ago" Get rid of it. And I don't ever want to see that shit again. Linus" And this is why Linux dominates practically all computing platforms everywhere.
- jaytaylor 11y agoHow much if any of this is just bike shedding? I'm all for not pulling in useless broken code, but why the public rant?
- archimedespi 11y agoThis is just Linus being Linus - he's like this quite a bit. He's... very opinionated.
- epistasis 11y agoThere's opinionated, and there's toxic, and I would argue that this is far more of the latter. That said, people in powerful positions will often get away with this, without many larger negative consequences. With that much power and influence comes a lot more slack in the way one behaves. I don't have much tolerance for Linus like behavior in places that I work day-to-day though, without a lot of protective social niceties.
- ciupicri 11y agoToxic?! He's just harsh and with a good reason. I find sugar coating way more toxic than what Linus did.
- gnarbarian 11y agoStrong language and mean words aren't toxic. I'd rather know the boss is pissed off than have him smile to my face while slowly hating my guts more and more. If you don't let people blow off steam and express their honest opinions people bottle it up and you end up with a nasty passive aggressive, underhanded environment where everyone is lying and that's actually toxic.
- vehementi 11y agoAre the only possible options swearing at employees or tricking them into thinking you're happy while you secretly are upset with their code quality?
- gnarbarian 11y agoWhen communication is carried out over text it can be difficult to convey seriousness, intent,tone and emotion behind overly professionally sanitized HR speak. Linus' example here is marvelous in comparison and gets his point across quite well.
- deleted 11y ago[deleted]
- deleted 11y ago[deleted]
- kawsper 11y agoIf Finns are anything like us Danes, they actually like to swear a lot. DHH has some of it as well, and it seems it isn't meant as bad or as rude as native english speakers understands it. David wrote about it here, https://signalvnoise.com/posts/1214-profanity-works https://signalvnoise.com/posts/1214-profanity-works
- gnarbarian 11y agoBecause if we're here talking about it, there's a chance people will remember to not do it next time. Also it's cathartic.
- deleted 11y ago[deleted]
- NhanH 11y agoIt's not bike shredding. Development project almost always die by a thousand cuts that needs to be avoided one LOC at a time.
- jmpeax 11y ago"Out to lunch", "bike shedding". Ironic how colloquialisms are used so freely in an industry that despises counter-productive complications.
- jaytaylor 11y agoTo be clear: I wasn't immediately sure if it's Linus doing the bike shedding- In fact it appears to me more like the PR is the culprit.
- jmpeax 11y agowtf does "bike shedding" even mean?!
- fnordfnordfnord 11y agohttp://catb.org/~esr/jargon/html/B/bikeshedding.html http://catb.org/~esr/jargon/html/B/bikeshedding.html https://en.wikipedia.org/wiki/Parkinson's_law_of_triviality https://en.wikipedia.org/wiki/Parkinson's_law_of_triviality Or: http://www.urbandictionary.com/define.php?term=bikeshedding http://www.urbandictionary.com/define.php?term=bikeshedding
- jmpeax 11y agoYeah, I can google too, just kernel developers can find what the function overflow_usub does. That's not the point.
- Sanddancer 11y agoThe rant is about being overly fancy with the code and making it hard to read. If one scans the line, the thing that stands out first is the function being used. Not only is it a gccism that has never been used before, but it's a gccism that is used in a poor manner. By copying the "safe" subtraction to the same variable, you've now changed the behavior of the function. Before, if the mtu was too small, it would goto the error handler and not alter the mtu. The new function, if the resulting value is between 0 and 7, will overwrite mtu, match the second conditional, and be shipped off to the error handler with a new, invalid, value. The second part of cleverness is in fact even more damning than that. The conditional || mtu <= 7 is a siren's call for anyone looking for a cheap optimization. To someone not paying attention, this looks like it could be a nice patch -- take out an or that couldn't possibly be true under any circumstance, and save a few ops on every incoming packet. Bundle it in with other optimizations, and you've got an overflow just waiting to go off. So no, it's not bikeshedding, it's being too clever for one's own good, and in one line adds a new function call that's just barely been proposed for a standardized version of C, and has a pair of logic errors to boot. In short, ticking off pretty much everything you don't want to do in a line of code.
- heavenlyhash 11y agoThank you: the most comprehensive (and damn near only) comment on the page that talks about the technical decision being represented here.
- JSno 11y agoit was indeed a piece of shitty code. Linus has right to protect his baby.
- cbd1984 11y agoif (overflow_usub(mtu, hlen + sizeof(struct frag_hdr), &mtu) || mtu <= 7) goto fail_toobig; Any code which relies on the short-circuiting behavior of a logical operator in such an obscure way is bad code. Linus may have gone a bit overboard in his critique, but, again, it was almost all criticism of the code, not the person. The only criticism of people is him calling people who like that code "out to lunch". In short, I'm not seeing a meltdown.
- chetanahuja 11y agoAgreed. The code is abominable. I would have developed rage looking at that checkin in my project too. Although since I'm not Linus, I might have checked my rage a bit and used words like "disappointing" and "unnecessarily complex".
- tobinfricke 11y agoRelying on the short-circuiting behavior of || and && in C is a long-accepted idiom. It's practically the purpose of those operators. https://en.wikipedia.org/wiki/Short-circuit_evaluation#Common_usage https://en.wikipedia.org/wiki/Short-circuit_evaluation#Commo...
- damienkatz 11y agoThe obscure part is relying on a side effect of the first clause in the second clause.
- haberman 11y agoThat is pretty common and readable for '&&', but I agree it is too subtle and obscure for '||'.
- woodman 11y ago> Any code which relies on the short-circuiting behavior of a logical operator is bad code. What is obscure about it? I hate to think about how even more verbose C would be without short-circuiting. Now if there had been a side effect... well, it would still be debatable - but at least you'd have a watered down cert recommendation to point to.
- monochromatic 11y agoIf you think that's a meltdown, this must be the first Linus thread you've read.
- abvdasker 11y agoThis one is my favorite: https://lkml.org/lkml/2012/12/23/75 https://lkml.org/lkml/2012/12/23/75
- monochromatic 11y agoThat's more like it. What a prick.
- chris_wot 11y agoYup, I agree. Is Mauro still contributing to the Linux kernel?
- AnkhMorporkian 11y agoReally the title should be edited to "Linus is uncharacteristically nice to a contributor."
- deleted 11y ago[deleted]
- icpmacdo 11y agoThere just pulling it from this article http://thenextweb.com/dd/2015/11/02/linux-creator-linus-torvalds-had-a-meltdown-over-a-pull-request-and-it-was-awesome/ http://thenextweb.com/dd/2015/11/02/linux-creator-linus-torv...
- Jupe 11y agoYes, simplicity... what a concept. Something the software engineering discipline seems to either loathe, be afraid of, or just want to avoid at any cost. For example, why something as simple as 'git pull' has had so much confusion and discussion. Why there are millions of views on S.O. on just the differences between pull and fetch? http://stackoverflow.com/questions/292357/what-are-the-differences-between-git-pull-and-git-fetch http://stackoverflow.com/questions/292357/what-are-the-diffe... ==> Viewed: 1080104 times Good code doesn't just pass unit tests. It should be know-able, think-able, make some level of sense and generally be easily understandable.
- userbinator 11y agoSomething the software engineering discipline seems to either loathe, be afraid of, or just want to avoid at any cost. I think it has to do with the fact that a lot of developers are taught that abstraction/indirection are good things (and to a certain extent, they are), and can be used to manage complexity; but not that they're more of a last-resort option compared to actually making the design as simple as possible. Linus' rant about "helper functions" reminds me of a time when I taught an intro programming course and helped a student who, when faced with not knowing how to solve a problem, decided to take "write a helper function" as his mantra (apparently he read that somewhere in a book) and ended up with around a dozen-level-deep nested set of functions that turned out not to do anything useful at all - each one just called another and returned its result, except the deepest one, which he came to ask me about. He thought that the solution would somehow come to him more easily the more "abstract" (in his terms) the code became, and went steadfastly down that path - until common sense took over and he came to me wondering what he did and why it didn't work.
- alxmdev 11y agoWe are still in the first century of software development, I doubt any code written today will be relevant by the time we enter the second. The computer science class of 2065 will enjoy seeing all these chaotic things we made, running in virtual machines hosted by museums that are yet to be built :-)
- 11y ago
- Maxious 11y agoLinus’s Rant Rewritten http://catcode.com/comments/2015/cf20151101.html http://catcode.com/comments/2015/cf20151101.html
- fnordfnordfnord 11y agoToo weak. Uses weasel words. ie: "Consider this replacement:" Linus' version is obviously too strong for some peoples' tastes, but the rewritten version doesn't send a clear message. A lot of things can be said about Linus' typical comments, but the messaging being ambiguous is not one of them.
- deleted 11y ago[deleted]
- TallGuyShort 11y agoThat's like saying charities don't do anything because there are still homeless people. You can improve a problem without eliminating it.
- mark-r 11y agoAt his scale, any little bit helps, and crap is guaranteed to get through regardless. Can you imagine how worse it would be if he didn't lay down the law?
- santaclaus 11y agoI've seen this sort of language creeping into discussions over the past year or two, and it feels quite strange. Lots of phrasing statements of fact as questions, etc. I'm not sure what this accomplishes -- it certainly makes the heart of many technical discussions harder to get to.
- oxryly1 11y ago> "Consider this replacement:" Those aren't weasel words, that's direct feedback. The rewritten message clearly indicates a rejection of the submitted code, so directing the submitter to consider the example replacement seems a constructive and appropriate response. The rewritten version neglects the criticism that the submitted code is too fiddly relying on the short-circuit of the || operator, but Linus failed to mention that as well :p
- deleted 11y ago[deleted]
- striking 11y agoDon't call it a meltdown for goodness' sake. Linus only gives this treatment to the prima donnas at his level to keep them in place. It may sound impolite to say so, but some of them act as if they're God's gift to Earth. Linus is doing what he needs to do to keep everyone in their place. Some of these programmers don't like taking no for an answer. I've been that guy before. I've been a real butthead to people with my code. So I respect what Linus is doing. Because I had it coming, and so did the recipient of this rant.
- fnordfnordfnord 11y agoI too, have been a pompous ass before (probably still am from time to time), but I'm much happier with the things I say in public after having had it pointed out to me a couple of times early on.
- RogerL 11y ago"No problem, I'll revert it all." - direct quote from the so-called "prima donna".
- striking 11y agoTry this email http://lkml.iu.edu/hypermail/linux/kernel/1510.3/02919.html http://lkml.iu.edu/hypermail/linux/kernel/1510.3/02919.html >> Get rid of it. And I don't ever want to see that shit again. > I don't want to give up on that this easily
- csvan 11y ago"Prima donna"??? Did you even read the guys responses? They are as calm and collected as anything.
- tareqak 11y agoThe title of this post is editorialized. I do think the topic is worthy of discussion though, so I upvoted it. In spite of the tone and language, Torvalds manages to keep the issue fairly impersonal (The reference to 'braindamage' sort of crosses the line). Nowhere does he specifically call any specific individual out, even though he easily could with git blame on the specific line as well as grabbing the author, committer(s), and reviewers (individuals responsible for signing off the commit) information from git log. Still, if my code received that sort of treatment, I would probably be in tears.
- Alex3917 11y ago> if my code went that sort of treatment, I would probably be in tears. I think the reason Linus feels justified in being an asshole is that he feels you can't accidentally write code this way. Rather, he thinks it's someone trying to make themselves look smart at the expense of the project, which is itself assholish behavior. I'm not saying he's right, but if you look at it from his perspective it's at least logically consistent.
- oxryly1 11y agoIf I maintained a large project and saw a pull request like that I'd lose my cool as well. Linus clearly needs better and more thorough subsystem maintainers so code like that gets corrected (or rejected) earlier.
- Jerry2 11y agoWhat a horribly editorialized 'clickbait' title.
- ps4fanboy 11y agoLinus is really incompatible with the way Software Engineering (safe spaces, toxic, problematic) is going, it is going to be a very enjoyable show to see the two sides butt heads constantly as they disagree with how he deal with people.
- gnarbarian 11y agoWhat leads you to believe that it's actually going that way? A couple high profile winers with too many twitter followers and no horse in the race does not a trend make.
- deleted 11y ago[deleted]
- deleted 11y ago[deleted]
- devnonymous 11y agoFWIW, here's the author's response to linus's criticism: http://lkml.iu.edu/hypermail/linux/kernel/1510.3/02919.html http://lkml.iu.edu/hypermail/linux/kernel/1510.3/02919.html meh, it's just another day at lkml, not a meltdown.
- llamataboot 11y agoIf anyone wrote a code review this way at a workplace, they would likely be reprimanded, do it again and likely fired. I'm not sure why we can't expect basic levels of professionalism out of project maintainers, much less decency.
- chris_wot 11y agoThat's not the point of code reviews. If you fired someone for this, then you are a remarkably bad manager. Please don't ever manage people. Thanks.
- kyriakos 11y agoPleasant fellow
- chris_wot 11y agoThe response can be found here: http://lkml.iu.edu/hypermail/linux/kernel/1510.3/03200.html http://lkml.iu.edu/hypermail/linux/kernel/1510.3/03200.html From: Rasmus Villemoes Date: Wed Oct 28 2015 - 10:30:41 EST On Wed, Oct 28 2015, Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx> wrote: > Hi Linus, > > On Wed, Oct 28, 2015, at 10:39, Linus Torvalds wrote: >> Get rid of it. And I don't *ever* want to see that shit again. > > I don't want to give up on that this easily: > > In future I would like to see an interface like this. It is often hard > to do correct overflow/wrap-around tests and it would be great if there > are helper functions which could easily and without a lot of thinking be > used by people to remove those problems from the kernel. I agree - proper overflow checking can be really hard. Quick, assuming a and b have the same unsigned integer type, is 'a+b<a' sufficient to check overflow? Of course not (hint: promotion rules). And as you say, it gets even more complicated for signed types. A few months ago I tried posting a complete set of fallbacks for older compilers (https://lkml.org/lkml/2015/7/19/358), but nothing really happened. Now I know where Linus stands, so I guess I can just delete that branch. Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- pajtai 11y agoI would guess this discourages some good programmers who would have strong positive impact from trying their hand at helping out with the kernel.
- nxnfufunezn 11y agoAm I the only one who finds this fine and completely appropriate?
- zuron7 11y agoTo be fair, Linus is the boss. He is the one who controls the Linux kernel development and just like at any firm, if the employees aren't doing a good job, they get shouted at. The difference here being that Linus' rants are in the public because of lkml while the scalding meted out by other bosses remain in the confines of their respective offices. Just another day at work here.
- DoubleMalt 11y agoOn a tangent: http://blog.dilbert.com/post/129215160011/why-trump-insults-people-part-of-my-trump http://blog.dilbert.com/post/129215160011/why-trump-insults-... Also: Linus rarely insults people, he criticizes the code, albeit harshly. http://blog.codinghorror.com/egoless-programming-you-are-not-your-job/ http://blog.codinghorror.com/egoless-programming-you-are-not...