4 ms·
Eventually Linux will find out that those new overflow functions produce better ASM code by checking the overflag FLAG. This is in HW, use it, and don't fallbac
by rurban 11y ago
Eventually Linux will find out that those new overflow functions produce better ASM code by checking the overflag FLAG. This is in HW, use it, and don't fallback to inline assembly.
jo +2 is much better than the previous code, even if the C function looks insane, yes. I agree with that. I also replaced all our crazy manual overflow checks with these new builtins, and with mult and signed add/sub it made it much faster and easier to read. The uadd/usub cases are indeed quirky, but at least consistent.
Summary: Linus is way off here.