3 ms·
It also depends on what you mean by commit. Are we talking 5 commits in 1 merge request (Git style), or 5 individual pieces of code to be reviewed separately?
by dcherman 11y ago
It also depends on what you mean by commit. Are we talking 5 commits in 1 merge request (Git style), or 5 individual pieces of code to be reviewed separately?
In any case, I think 5 per week is extremely reasonable; I actually do less these days. I used to commit a dozen or more times per week, but these days I tend to work on the larger and harder components that people require. That means more thought and more design. It's not doing less work, it's just doing harder work.
This person may also have had review reponsibilities. Doing a truly thorough code review takes time to complete, and that time is time that you're not coding. It's important though; I may not be coding while I'm reviewing, but I'm sharing knowledge with a dozen other developers who hopefully learn from it (as I learn from others reviewing my own code). In aggregate, I hope that my lack of frequent commits actually helps the company rather than hurts it since hopefully I'm enabling many others to do better work.