3 ms·

It's bash so pretty easy to audit

• coherentpony 11y ago
  The first thing I notice is a missing set -eu set -o pipefail at the top of the script, which is equivalent to ON ERROR RESUME NEXT in BASIC.
  • voltagex_ 11y ago
    https://github.com/zakjan/cert-chain-resolver/issues https://github.com/zakjan/cert-chain-resolver/issues - add an issue?
  • leni536 11y ago
    Note that "set -e" doesn't work in subshells so you have to be extremely careful if you make complex subshell commands or write set -e in every subshell too.
  • icebraining 11y ago
    Apparently, "pipefail" is a bashism, you can't use it on portable scripts.
  • deleted 11y ago
    [deleted]
  • zakjan 11y ago
    Author here. I used the options you mention before, however I found it highly unreliable. I have replaced them with better manual error handling and tests. Please review the latest code. I'm looking forward to any reported issues.
    • zakjan 11y ago
      Also I'm going to rewrite it to a different language, Shell was really just a quick hack. Probably in C. I want to keep it minimalistic in dependencies.
    • deleted 11y ago
      [deleted]