3 ms·
He identified a bug in the function `evaluateIntegerExpression` which parses an integer literal from LLDB, erroneously always parsing in base-16. But the pull
by erydo 11y ago
He identified a bug in the function `evaluateIntegerExpression` which parses an integer literal from LLDB, erroneously always parsing in base-16.
But the pull request he created (https://github.com/facebook/chisel/pull/117 https://github.com/facebook/chisel/pull/117) didn't fix that; instead it just replaced that function call with manually parsing the literal in the one specific place he was having problems with.
Did I miss something there? That seems like a really weird "solution". Why not just fix the original function?