3 ms·
A few issues: * Because you are only using http basic auth for authentication and aren't using cookies, if I reload the page or go back to the page later, I ha
by ryan_j_naughton 11y ago
A few issues:
* Because you are only using http basic auth for authentication and aren't using cookies, if I reload the page or go back to the page later, I have to log in again.
* You are generating the person UUID's client side in the backbone model as well as initializing data (like contacted:false) for a new person. UUIDs and default values are better created server-side as you should never trust that your client side code hasn't been tampered with or that someone isn't hitting your app programatically.
* based on how chrome handles saving the login credentials and password, it tries to autofill the e-mail address but your system expects the username.
I'm pointing these out because I really like this app idea, and I'd like to use it and see it improved.
- curuinor 11y agoI wanted to learn http basic auth and not have to deal with cookies, and it is sort of the pattern for usage that you never have to deal with this thing more than once every few weeks. But I guess I could add cookies or localstorage or something. I do do some server-side checking to deal with UUID tampering, but I guess that is a better idea to handle it all server-side. The email autofill is an easy fix, thank you! I didn't notice because I autofill nothing. I actually have no idea whether it's a good idea or not in the abstract, but I've been using it and it works for me and I like it, so I wanted to share it. It's good that you liked it!