3 ms·
Awesome, thanks for the detailed feedback. - Great point on permissions. I'm certainly going to do some digging to see how many people get turned away by that
by davegaeddert 11y ago
Awesome, thanks for the detailed feedback.
- Great point on permissions. I'm certainly going to do some digging to see how many people get turned away by that level of access. I could definitely understand if people are cautious with that, as you were, because they should be!
- The prevention of commits to master all happens via GitHub's new protected branches feature (they use Git hooks I believe). You're right, preventing force push is part of it, but the other thing it can do is require status checks (PullApprove is just another status check) on all commits to your base branch -- meaning nothing can be directly committed to the base branch, but should instead run through a pull request. Pretty interesting stuff: https://github.com/blog/2051-protected-branches-and-required-status-checks https://github.com/blog/2051-protected-branches-and-required...
- Thanks for sharing this one, I definitely wouldn't have thought of that without experiencing it myself.
- I'm planning on building some settings towards this. The most basic one giving an option that approval statuses go back to "pending" on new commits. It could possibly get more specific, giving an option to ignore whitespace changes etc...
- Nice idea. I'll throw this in the hopper.
Let me know if you have any other thoughts!