4 ms·
Maybe I missed something on the methodology, but I have a question regarding justification of designing a complete new tool. The article mentions "ImageMagick
by guepe 11y ago
Maybe I missed something on the methodology, but I have a question regarding justification of designing a complete new tool.
The article mentions "ImageMagick is slow because it does a lot more than just extract image size". So we implemented a complete new solution.
How about: "We added to ImageMagick a new command to just extract image size". So we published a small patch to Imagemagick, and got it done much faster than creating a complete new tool. On top of that, reusing tested Imagemagick data structure would probably reduce a lot maintenance cost.
Maybe I did not see some subtleties ?
- mkoryak 11y agothis is written entirely in javascript. If all you need is to get an image size, then installing imagemagick is overkill
- guepe 11y agoI see. So this is a "fast javascript implementation to retrieve size of {image, pdf}" And since process is a small task with many calls, it would be costly to call an external process (imagemagik) using native code.
- mgartner 11y agoThe overhead of shell calls in Node was a big reason why we avoided trying to patch ImageMagick or other command line program.
- ilurkedhere 11y agoHow bad is it when you call info ImageMagick's library via FFI?