5 ms·

That may be your personal opinion, but 15 'max(' on a single would not pass code review in any decently maintained project, especially when there is a cleaner,

That may be your personal opinion, but 15 'max(' on a single would not pass code review in any decently maintained project, especially when there is a cleaner, reusable alternative. Moreover, complaining that implementing such a macro is too cumbersome because it implies finding a place for it in your code structure certainly doesn't imply professionalism. Just step back a minute and imagine the fresh intern comes to you with this code and explanation. Would it fly? Or are you just finding excuses because he's the author of a well known library?

kibwen 11y ago
You're a bit too over-focused on so trivial an issue. The game in question is a lone developer's personal side project and isn't even open-sourced yet. Don't jump to the conclusion that a codebase written for fun and developed in isolation has any bearing on that developer's professional capabilities.
- Ace17 11y ago
  Interestingly, I think it might have. Would you rather hire a "clean code" lone developer, or a "messy" one?
  - kibwen 11y ago
    That's a loaded question, I deliberately wouldn't judge a candidate based on their undisclosed personal projects. :P tomaka is a well-regarded author of many high-quality libraries, such as https://github.com/tomaka/glium https://github.com/tomaka/glium . This is the output I would use to gauge his applicability for any hypothetical position.
- rootlocus 11y ago
  The article is not about a game, is about what could be improved in the core language, from a professional point of view. I may write messy code in my spare time, but I don't. And I certainly don't wait for the standard library to implement trivial things on my behalf complaining there's no alternative.
  - kibwen 11y ago
    If you read the OP, in literally the second comment tomaka admits that this is the least important item in the list. You characterization of his remarks as "complaining" is uncharitable.

kibwen 11y ago

You're a bit too over-focused on so trivial an issue. The game in question is a lone developer's personal side project and isn't even open-sourced yet. Don't jump to the conclusion that a codebase written for fun and developed in isolation has any bearing on that developer's professional capabilities.

Ace17 11y ago
Interestingly, I think it might have. Would you rather hire a "clean code" lone developer, or a "messy" one?
- kibwen 11y ago
  That's a loaded question, I deliberately wouldn't judge a candidate based on their undisclosed personal projects. :P tomaka is a well-regarded author of many high-quality libraries, such as https://github.com/tomaka/glium https://github.com/tomaka/glium . This is the output I would use to gauge his applicability for any hypothetical position.
rootlocus 11y ago
The article is not about a game, is about what could be improved in the core language, from a professional point of view. I may write messy code in my spare time, but I don't. And I certainly don't wait for the standard library to implement trivial things on my behalf complaining there's no alternative.
- kibwen 11y ago
  If you read the OP, in literally the second comment tomaka admits that this is the least important item in the list. You characterization of his remarks as "complaining" is uncharitable.