3 ms·
Cheers on using Reviewable for a better review process, but I notice it adds loads of useless text to the git commit messages[0]. I always figure that GitHub, R
by aorth 11y ago
Cheers on using Reviewable for a better review process, but I notice it adds loads of useless text to the git commit messages[0]. I always figure that GitHub, Reviewable, and other hipster things might not be around one day, so I have stopped using GitHubisms like "Fixes #1" and such in my commit messages, and instead referencing the commits from pull requests and issues. That way, when GitHub is gone at least the git commit history still makes sense ("Grandpa, what is GitHub?").
[0] https://github.com/servo/servo/commit/4dc986bca35f986e2f15f1591f120e1cef2810da https://github.com/servo/servo/commit/4dc986bca35f986e2f15f1...
- halflings 11y agoWhen Github will be gone (if that ever happens during your lifetime), will that extra clutter in your commit messages really matter that much?
- aorth 11y agoLook at commit messages in the Linux kernel, that's what we should be aiming for—whether GitHub or GitHubNext will be around or not isn't really the issue, just an easy thought experiment to illustrate the point. https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/ https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux....
- Manishearth 11y agoThe merge commit of pull requests in Github contains the PR text. Tomato, tomahto.