4 ms·
> more than one atomic change into a single commit There is no such thing as an "atomic change". Sometimes, fixing a single bug ,adding a single feature requir
by aikah 11y ago
> more than one atomic change into a single commit
There is no such thing as an "atomic change". Sometimes, fixing a single bug ,adding a single feature requires the edition of multiple files or even complex changes. I personally don't like these projects with 1 commit per file change ,that's ridiculous and it's noisy.
- gutnor 11y agoI think he mean a single feature. Like a single commit "Fix bug XYZ", that in reality also contains "Fix typo in error messages", "Change rendering of status page", "Fix test framework DSL to prevent infinite loop". Naively you could say that each of those should go in their own commit, but reality is that they may actually be quite small and necessary and may not even be seen as a feature by the author or reviewer. Only 6 months down the line, you read the code and wonder why the f*ck there is a change in the test DSL in order to fix bug XYZ.
- nanny 11y ago>Sometimes, fixing a single bug ,adding a single feature requires the edition of multiple files Congrats, that's one atomic change. He didn't say "one commit per file change", he said "one commit per atomic change", and yes, sometimes those atomic changes can spread across multiple files.