4 ms·
It's not strlcpy he had an issue with. His issue was converting a whole lot of code over to strlcpy() while introducing bugs that didn't previously exist. For
by teacup50 11y ago
It's not strlcpy he had an issue with.
His issue was converting a whole lot of code over to strlcpy() while introducing bugs that didn't previously exist.
For another example of this kind of irrational thinking, look at NeoVim's massive churning changes to the Vim codebase for the purposes of "modernization".
- justinmk 11y agoWhat changes to Neovim are you referring to? We are generally very careful about "cleanup" patches in Neovim. Some examples: https://github.com/neovim/neovim/pull/2418 https://github.com/neovim/neovim/pull/2418 https://github.com/neovim/neovim/pull/1788 https://github.com/neovim/neovim/pull/1788 https://github.com/neovim/neovim/pull/1340 https://github.com/neovim/neovim/pull/1340 At least one tangible benefit to some of these changes is that it allows us to enable -Wconversion. We've also rejected dozens of cleanup patches for quality reasons.
- deleted 11y ago[deleted]
- shmerl 11y agoI didn't track the style of Neovim changes, but I appreciate them actually making a moving project. vim has bugs and feature requests which aren't fixed for years. I'm using Neovim currently and really enjoy that it supports stuff like 24 bit color schemes in the terminal. I finally can use color schemes which don't hurt my eyes.