4 ms·
this one made me think on improvement refactorings that always break something, even though the old code needed improvement. Specially just before releases.
by vfc1 11y ago
this one made me think on improvement refactorings that always break something, even though the old code needed improvement. Specially just before releases.
- mreiland 11y agoThe best time to push to production is Friday afternoon, everyone knows that!
- Mtinie 11y agoAgreed! Do you wait until the Friday afternoon right before your DevOps lead is scheduled to leave for a well-deserved vacation, too? In my experience it really takes things to a whole new level of awesome!
- protomyth 11y agoHaving been the victim of a DBA pulling that stunt, my blood pressure still goes up a bit when its mentioned.
- AnimalMuppet 11y ago"I don't always test my code. But when I do, I test it in production." Credit where due: I stole that from a co-worker named Kalen Braley. (He doesn't actually do that, as far as I know.)
- deathanatos 11y agohttps://www.thinkgeek.com/product/f141/ https://www.thinkgeek.com/product/f141/ — if you want it on a shirt :-)
- AnimalMuppet 11y agoAh. So my coworker stole the saying, just like I stole it from him.
- voltagex_ 11y agoThose kind of refactorings are what really made me believe in CI and good unit tests. It doesn't pass? You don't commit it!
- vfc1 11y agoBut if the CI breaks means you already committed it, and it will get pushed to production, too late!
- lobo_tuerto 11y agoNo, that's exactly what CI services an pushing to candidate branches are for.
- gamegoblin 11y agoIf one's CI does not have a pre-production stage with integration tests, automatic blockers, and automatic rollback, one should rethink their CI design.
- softawre 11y agoGerrit is a thing (and you should run your tests locally, if you can)
- voltagex_ 11y agoSorry, I should have said "if it doesn't build, you don't merge it"
- aprdm 11y agocommit -> CI -> PASSES TESTS -> DEPLOY how is it going to be pushed to production if it fails tests ? :P
- draw_down 11y agoHow will it get pushed to production if there is no build artifact, because the build failed? This is what CI is.
- aardvark179 11y ago