3 ms·
>3. Coders should expect to get reviews every one or two days, otherwise they will build up a substantial amount of changes that will take longer to process. Ad
by gargarplex 11y ago
>3. Coders should expect to get reviews every one or two days, otherwise they will build up a substantial amount of changes that will take longer to process. Additionally they may even forget why they made earlier changes!
NOT ACCEPTABLE.
Rationale should be documented in the ticket, and the ticket should be tagged in the commit message.
Any engineer rationale MUST be documented clearly with comments for all reviewers.
- hacker_9 11y agoI find that 1-2 days, maybe 3, is a good number before getting a review. This doesn't mean they have to be finished with their piece of work, or that they even have to commit the code at the end of the review, this is just so a second pair of eyes can see it and both can agree that they are on the right track. Then when the functionality is complete, the same reviewer can glance over the already reviewed sections before focusing mainly on the new changes.