4 ms·
In hindsight, my comment seems rather curt and dismissive. Thanks for taking my criticisms like a champ. Honestly, I don't think ag is very good code. It's wor
by ggreer 11y ago
In hindsight, my comment seems rather curt and dismissive. Thanks for taking my criticisms like a champ.
Honestly, I don't think ag is very good code. It's worth reading if you want to see optimizations like memory-mapped I/O, pthreads, Boyer-Moore strstr, etc. But if I had to grade the quality of the code, I'd give it a C-. Many parts have grown organically, and I haven't had time to restructure them. Also, ag's use-case is not exactly mission-critical. Nobody is going to die if it crashes or errors-out. Add my time constraints and… the result is some shoddy code.
I'll add "C Programming Guidelines" to my queue of blog posts to write, but I make no guarantees about when I'll get to it. Sorry.
- btrask 11y agoCool, I'm looking forward to it.