3 ms·
Seems nice! I would use this to avoid all the OpenCL bloat code. However, there's an inconvenient: why restrict the vector sizes to be all the same? I see that
by gjulianm 11y ago
Seems nice! I would use this to avoid all the OpenCL bloat code. However, there's an inconvenient: why restrict the vector sizes to be all the same? I see that it is used to set the workgroup size. I think that giving the possibility to pass arrays of whatever size and allowing the client to set the workgroup size wouldn't add much complexity to the code nor to the API.
Apart from that, really nice work, the code is well written and commented, it's a joy reading things like that.
- Gladdyu 11y agoI still have some plans to auto-derive the optimal work/global/local group sizes, however, that still takes some work. Therefore, I just implemented the most basic straightforward alternative (which is indeed rather restrictive at the moment) as a temporary solution.
- gjulianm 11y agoThat's great! IIRC, OpenCL can calculate automatically the local workgroup sizes so you only have to provide the global size.