3 ms·
"The composes keyword says that .normal includes all the styles from .common" -- great, except you have the meaning of the word reversed. In the context above i
by lo_fye 11y ago
"The composes keyword says that .normal includes all the styles from .common" -- great, except you have the meaning of the word reversed. In the context above it actually means ".normal is part of .common", which is clearly not the intent. If you wanted it to mean that ".normal includes all the styles from .common" then .normal should be "composedOf: common"
- martin-adams 11y agoCorrect. Would the word 'comprises' be more appropriate?
- lo_fye 11y agoOh, yes, I like that much more :) I've created this as an issue on their github repo, at https://github.com/css-modules/css-modules/issues/24 https://github.com/css-modules/css-modules/issues/24
- bobwaycott 11y agoI stumbled upon the Github issue and then found the HN reference. I commented with some additional thoughts and keyword options. I don't think 'comprises' would be the best choice here; it has quite a stricter meaning than 'includes' and its synonyms.
- martin-adams 11y agoWhat about 'inherits' or 'extends' to match known programming terms?
- acjohnson55 11y agoReminds me of the one-man Wikipedia crusade against this misusage: http://www.npr.org/2015/03/12/392568604/dont-you-dare-use-comprised-of-on-wikipedia-one-editor-will-take-it-out http://www.npr.org/2015/03/12/392568604/dont-you-dare-use-co...