3 ms·
> Replacing headers with a standard header is pretty common. It shouldn't be. That's a fundamentally bad idea. It'd be reasonable to put a standard header at
by JoshTriplett 11y ago
> Replacing headers with a standard header is pretty common.
It shouldn't be. That's a fundamentally bad idea.
It'd be reasonable to put a standard header at the top, immediately followed by "Based on (other project):" and the header for that project. But changing those headers is never OK.
- teamhappy 11y ago> It shouldn't be. That's a fundamentally bad idea. I don't think it's that bad of an idea. The MIT license says: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. What that means is anybody's guess. I'd say if you include one copy somewhere you're pretty much off the hook.
- teacup50 11y agoA source file is reasonably "a substantial portion"; in fact, a per-file license is applicable to that file, and does not cover other files.
- teamhappy 11y agoYup. I'm saying (guessing, really) the header doesn't necessarily have to stay in the file. You might as well put it somewhere else (e.g., docs, license file). --- Per-file licenses are different. The only one I looked at is MPL2 and IIRC it mentions the little note doesn't have to be in the file.
- JoshTriplett 11y agoIt's theoretically possible to comply with that license while moving the notice elsewhere, sure. However, for the purposes of avoiding situations like this, it's a bad idea. Much easier to just keep the license in the file exactly as it was, and add a header above it if needed.
- DannyBee 11y agoSorry, i think you misunderstand. I meant: "Replacing your internal copyright/whatever headers" with a standard license header before releasing. Not "erasing MIT license headers", which is completely wrong.
- JoshTriplett 11y agoAh, I see. As in, automatically replacing a "Internal use only, do not distribute" header or similar with a header suitable for external release? Sure, that makes more sense.
- DannyBee 11y agoYes, and my suspicion is that this is essentially what MS messed up. Someone probably wrote a script (as often happens) that removes the first comment block (which they expected to be some internal-use +copyright comment) or something similar and added their headers , and it got applied to these files. I know this, because we've stopped people from making the same mistake :)