3 ms·
Negative, we're actually editing the commit author credentials when we create the final commit message, which adds a Changelog message and closes the original P
by mmcclure 11y ago
Negative, we're actually editing the commit author credentials when we create the final commit message, which adds a Changelog message and closes the original PR.
https://github.com/videojs/video.js/blob/master/contrib.json#L358 https://github.com/videojs/video.js/blob/master/contrib.json...
- hk__2 11y agoWhy not just doing a rebase? I work on a big open-source project on Github and we do rewrite/squash commits to have a clean history, but it only involves a rebase, not editing the author credentials.